StEEmcClusterMaker: avoid using operator++(bool&)#274
Merged
plexoos merged 1 commit intostar-bnl:mainfrom Jan 18, 2022
Merged
Conversation
The code is roughly equivalent to:
bool used[];
for(;;) {
// ...
if (used[istrip]) break;
// ...
used[istrip]++;
// ...
}
The use of operator++ for a boolean value is not wrong, but is slightly confusing and leads to a compilation error in C++17:
.sl79_gcc485/obj/StRoot/StEEmcPool/StEEmcClusterMaker/StEEmc2x2ClusterMaker.cxx:355:16: error: use of an operand of type 'bool' in 'operator++' is forbidden in C++17
355 | used[istrip]++;
| ^~
.sl79_gcc485/obj/StRoot/StEEmcPool/StEEmcClusterMaker/StEEmc2x2ClusterMaker.cxx:391:16: error: use of an operand of type 'bool' in 'operator++' is forbidden in C++17
391 | used[istrip]++;
| ^~
veprbl
changed the title
Member
|
Ting, does this PR look OK to you? Thanks |
Member
|
Dmitri, let us merge it and close this PR. Thanks |
Member
|
Could you hit the approve button, Xin? |
starsdong
approved these changes
Jan 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code is roughly equivalent to:
The use of operator++ for a boolean value is not wrong, but is slightly confusing and leads to a compilation error in C++17: