Merged
Conversation
Member
|
@akioogawa @kehw Any last comments before we merge this? Line 5 in 7794c76 |
Contributor
Author
|
@plexoos - The codeowners are correct. (Me, Tonko, Akio, Hongwei). Tonko and I are responsible for the majority of the code there, but both hongwei and akio have parts of it. |
Contributor
|
Are you done adding, @jml985? |
akioogawa
approved these changes
Feb 1, 2022
Contributor
Author
|
@kehw Yes, I'll be opening another for the specific Jevp code updates. You can go ahead and accept these. |
plexoos
approved these changes
Feb 3, 2022
genevb
pushed a commit
that referenced
this pull request
Feb 8, 2022
Successfully resolves a memory error when reconstructing iTPC clusters that was introduced in PR #288 .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please do not yet review or accept this. I will be adding files one by one to see what (if anything) breaks the CI tests