Skip to content

FCS Y position change based on measurements#291

Merged
plexoos merged 1 commit intostar-bnl:mainfrom
akioogawa:pr20220131
Feb 7, 2022
Merged

FCS Y position change based on measurements#291
plexoos merged 1 commit intostar-bnl:mainfrom
akioogawa:pr20220131

Conversation

@akioogawa
Copy link
Copy Markdown
Contributor

FCS Y position change based on measurements

  • Geometry file changes for Y position
  • Associated StFcsDb changes for default fofsets
  • Fix StFcsDb::getHcalProjectedToEcalY()
  • Update associated Offline DB pushing macro for new detector geometry
  • Also update of Offline DB macro for fcsGain
  • A small modification on StFcsWaveformFitMaker's peak finder
  • New StSpinPool/StFcsEcalHcalMipMaker as example of finding Ecal-Hcal correlation
  • Adding tofmult and BBC/VPD/TPC vertex to StSpinPool/StFcsPi0FinderForEcal as an example

Copy link
Copy Markdown
Contributor

@klendathu2k klendathu2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine to me. (I did not review SpinPool codes, as these are not to be used in production context).

With respect to geometry. I presume that there will be no movement of the detector between runs. If not, we should consider setting up misalignment tables to apply run-to-run changes.

@akioogawa
Copy link
Copy Markdown
Contributor Author

Thanks!

Yes I think StSpinPool makers will not be used in production.

After we closed Ecal & Hcal on Dec20, we have not touched detector position (we measured Y position). It is already in offline DB as fcsDetectorPosition for when we open and close. I doubt we'll ever do serious MC for open position (nor physics data taking with it). I don't think Ecal and Hcal moved run by run. So I see no need for misalignment tables for run by run.

@starsdong
Copy link
Copy Markdown
Member

Dmitry, Daniel, Zilong, could you please take a review of the PR, comment or approve it? The changes look good to me.

@starsdong
Copy link
Copy Markdown
Member

Dmitri, let us merge this in. Daniel is likely tied with preparation for the upcoming collaboration meeting.

@plexoos plexoos merged commit 51b43ed into star-bnl:main Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants