FCS Y position change based on measurements#291
Conversation
klendathu2k
left a comment
There was a problem hiding this comment.
Everything looks fine to me. (I did not review SpinPool codes, as these are not to be used in production context).
With respect to geometry. I presume that there will be no movement of the detector between runs. If not, we should consider setting up misalignment tables to apply run-to-run changes.
|
Thanks! Yes I think StSpinPool makers will not be used in production. After we closed Ecal & Hcal on Dec20, we have not touched detector position (we measured Y position). It is already in offline DB as fcsDetectorPosition for when we open and close. I doubt we'll ever do serious MC for open position (nor physics data taking with it). I don't think Ecal and Hcal moved run by run. So I see no need for misalignment tables for run by run. |
|
Dmitry, Daniel, Zilong, could you please take a review of the PR, comment or approve it? The changes look good to me. |
|
Dmitri, let us merge this in. Daniel is likely tied with preparation for the upcoming collaboration meeting. |
FCS Y position change based on measurements