Merged
Conversation
Member
|
Hi Yuri, Thanks. I see the new added file ...y2016.C. Just want to be sure that this PR is also needed for the Run19 BES-II embedding? Thanks |
iraklic
reviewed
Feb 1, 2022
iraklic
approved these changes
Feb 2, 2022
starsdong
approved these changes
Feb 2, 2022
Contributor
|
Regarding this unanswered question...
On Feb 1, 2022, at 5:44 PM, Xin Dong ***@***.***> wrote:
Just want to be sure that this PR is also needed for the Run19 BES-II embedding?
My understanding is that this PR is not to be back-propagated as it affects real data reconstruction and was not used in the real data production for old libraries.
That said, I believe this exclusion of hits on dead RDOs *should* be in place for BES-II productions, along with exclusion of hits on lowered anode HV sections (lowered to the point of negligible gains, e.g. less than 1%). These were to-do items for the TPC group because some noise was seen during BES-II under both conditions that could have been picked up on reconstructed tracks. Since this one is merged, a separate PR will need be made for the anode HV exclusion. And then both of these will be included in future libraries (maybe it's about time to freeze SL22a).
Thanks,
-Gene
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove junk cluster due to masked out RDO