Fix crash in StFcsPi0FinderForEcal with MuDst VPD vertex in FastOffli…#299
Merged
jdbrice merged 1 commit intostar-bnl:mainfrom Feb 14, 2022
Merged
Fix crash in StFcsPi0FinderForEcal with MuDst VPD vertex in FastOffli…#299jdbrice merged 1 commit intostar-bnl:mainfrom
jdbrice merged 1 commit intostar-bnl:mainfrom
Conversation
…ne/BFC. StFcsWaveformFitMaker's Default for mEnergySelect separated for Ecal,Hcal(gaus fit) & Pres(Sum8) to speed up. Also When too many peaks are found, take sum8 instead of just quit fitting.
zlchang
approved these changes
Feb 11, 2022
genevb
approved these changes
Feb 11, 2022
Contributor
genevb
left a comment
genevb
left a comment
There was a problem hiding this comment.
The checks on null pointers look good to me. I'm guessing that a null StMuDst::btofHeader() was the reason for the crashes we were seeing. Other than those fixes, most of it is details for experts to understand. I don't see anything obviously questionable in this PR, so I don't object.
veprbl
approved these changes
Feb 13, 2022
jdbrice
approved these changes
Feb 14, 2022
Contributor
jdbrice
left a comment
jdbrice
left a comment
There was a problem hiding this comment.
These changes look good to me. I am approving and merging (since I am second to sign off)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix crash in StFcsPi0FinderForEcal with MuDst VPD vertex in FastOffline/BFC.
StFcsWaveformFitMaker's default for mEnergySelect separated for Ecal,Hcal(gaus fit) & Pres(Sum8) to speed it up. Also when there are too many peaks found, take normalized sum8 instead of just quit fitting.