Simu pp200 run14 pythia8 hfjets#315
Conversation
….bnl.gov/STAR/node/57884. Utilizes the libfastjet library to implement jet finding functionality. Identifies jets which contain D0 particles. This is an initial release, with much of the functionality hardcoded. After confirming filter is functioning as expected, will generalize the hardcoded functionality.
entries added by pythia are not required in the particle DB. Also, add additional context to the exception which gets thrown.
…nks. Reduce verbosity.
klendathu2k
requested review from
genevb,
perevbnlgov and
plexoos
as code owners
genevb
left a comment
genevb
left a comment
There was a problem hiding this comment.
Honestly, pretty much all of this PR is outside of my familiarity and I'm not very confident about what I'm approving here. Trusting Jason on this one.
starsdong
left a comment
starsdong
left a comment
There was a problem hiding this comment.
Trust Jason on this development. This has been used for embedding.
|
Dmitri, if you don't object, let us also merge this into main. Thanks |
| echo "Building FastJetFilter maker" | ||
| echo "" | ||
|
|
||
| cd star-sw-1 |
There was a problem hiding this comment.
Shouldn't this directory be created first?
This script does not seem like it can be used out of the box.
There was a problem hiding this comment.
This macro assumes the user has checked the code out of my repository, and builds. Once the pull request goes through, this is for documentation purposes only.
There was a problem hiding this comment.
That is a pretty strong assumption if you think about the long term code preservation and reproducibility.
| @@ -0,0 +1,10000 @@ | |||
| /star/simu/simu/gstardata/Simu2022/rcf22000/vertex_files/15165031_0014 | |||
There was a problem hiding this comment.
Is it possible to run the submitted macros as is without regenerating these files?
There was a problem hiding this comment.
Those files are an input dependency to the job. The format of the files are:
Run# Event# Vx Vy Vz...
Updating the macro with the specification. These files would need to be regenerated when comparing against any production of the data... (any change which alters vertex finding would require a new set of inputs).
There was a problem hiding this comment.
If you explain the format of the input files and how to regenerate them then there is not much point in including this particular list which, as you say, need to be regenerated for other data anyway.
|
Victor, it seems this PR needs your approval before merging. If you can take a look and comment/approve it. Thanks |
perevbnlgov
left a comment
perevbnlgov
left a comment
There was a problem hiding this comment.
I do not see anything suspicious
|
This PR appears to have failed the AutoBuild. I've opened issue #324 . |
|
This should be resolved by PR#325. Details in the commit message. But
the short summary is that I broke the build when I reorganized the
source tree (moved FastJetFilter one level higher). Cons no longer
matched the directory name, and did not apply the include for the
fast jet library.
(We were already in production for the simulation at that point, so
this did not impact the results).
…On 2022-03-10 23:36, Gene Van Buren wrote:
This PR appears to have failed the AutoBuild. I've opened issue #324
[1] .
--
Reply to this email directly, view it on GitHub [2], or unsubscribe
[3].
Triage notifications on the go with GitHub Mobile for iOS [4] or
Android [5].
You are receiving this because you authored the thread.Message ID:
***@***.***>
Links:
------
[1] #324
[2]
#315 (comment)
[3]
https://github.com/notifications/unsubscribe-auth/ANL4LVE5LRC5PJO2FN4ERNLU7LEWHANCNFSM5P23WZRA
[4]
https://urldefense.com/v3/__https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675__;!!P4SdNyxKAPE!VI6HJJ4SqUwT-kIH2oj7OGvGX8CoW5jDTrqViwHYfmiKhiN-ztyH2X6I5v5qw8U$
[5]
https://urldefense.com/v3/__https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign*3Dnotification-email*26utm_medium*3Demail*26utm_source*3Dgithub__;JSUlJSU!!P4SdNyxKAPE!VI6HJJ4SqUwT-kIH2oj7OGvGX8CoW5jDTrqViwHYfmiKhiN-ztyH2X6IaTpOllI$
|
5 participants
Addition of fast jet filter for HF jet simulation.
Fix to StarGenerator/DECAY -- advance past any pythia "system" entries when checking decay chains for validity.
Setup, macros and workflow for HF D0-jet simulation.