Skip to content

Tpc rdo mask fix#319

Merged
starsdong merged 3 commits intostar-bnl:mainfrom
fisyak:tpcRDOMaskFix
Mar 10, 2022
Merged

Tpc rdo mask fix#319
starsdong merged 3 commits intostar-bnl:mainfrom
fisyak:tpcRDOMaskFix

Conversation

@fisyak
Copy link
Copy Markdown
Member

@fisyak fisyak commented Mar 8, 2022

Two Updates:

  1. An additional correction for dE/dx handled by a new table identified by StTpcdEdxCorrection::kzCorrectionC which is currently activated only for the Run 19 AuAu200 data. The authors claim that the change won't affect any other dataset. A slide illustrating the related problem is available at https://drupal.star.bnl.gov/STAR/event/2022/03/09/SC-Management-Meeting/Run19-AuAu200-Calibration-Status

The change in StRoot/StDetectorDbMaker looks pretty safe as it only adds a diagnostic routine St_TpcAvgPowerSupplyC::PrintC()

  1. TPC RDO masking to deal with timestamp issue with full simulation for Run19 data (no impact on embedding).

@genevb
Copy link
Copy Markdown
Contributor

genevb commented Mar 8, 2022

I see there are changes to the TPC dE/dx codes here. Is this PR needed for dE/dx in Run 19 AuAu200?

-Gene

@genevb
Copy link
Copy Markdown
Contributor

genevb commented Mar 9, 2022

I see there are changes to the TPC dE/dx codes here. Is this PR needed for dE/dx in Run 19 AuAu200?

Yuri stated at today's S&C meeting that this PR is needed for embedding, but not reconstruction. In other words, if this doesn't make it into SL22a (which will be used to produce Run 19 AuAu200) now, Yuri wants it in SL22a eventually. He also implied it will be needed for other embedding libraries, but I'm not 100% sure which ones (all used to produce iTPC data so far?).

-Gene

@starsdong
Copy link
Copy Markdown
Member

Yuri, two quick questions

  1. I see this PR includes the commit d6e6217 which should be the same as in PR 317. So if this gets merged, we can drop out 317.
  2. On the TPC masking part, which datasets will need this? Or this is only for Run19 AuAu 200 GeV?

@starsdong
Copy link
Copy Markdown
Member

Here are the comments from Yuri:
"tpcRDOMask correction (PR319) is affect only simulation for Run XIX. It is not affected embedding. The game is with time stamp. The problem has been appeared when it is used simulation time stamp (2018-12-10). In embedding time stamp is coming from real data and this problem does not showed up."
I think we can go ahead with merging this PR. Since this includes PR 317, we can then ignore 317.

Copy link
Copy Markdown
Member

@starsdong starsdong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

@starsdong
Copy link
Copy Markdown
Member

Dmitry or Dmitri, please take a review. If no object, please approve and merge this PR. Thanks.

@starsdong
Copy link
Copy Markdown
Member

Dmitri, just to clarify, this PR is needed for the SL22a lib tag which will be used for the upcoming Run19 AuAu200 GeV production.

@starsdong
Copy link
Copy Markdown
Member

Thanks, Dmitry. I am going to merge this to main.

@starsdong starsdong merged commit 736832b into star-bnl:main Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants