Restore GetCVS() function in StTriggerSimuMaker#322
Merged
genevb merged 1 commit intostar-bnl:mainfrom Mar 10, 2022
Merged
Conversation
zlchang
approved these changes
Mar 10, 2022
starsdong
approved these changes
Mar 10, 2022
plexoos
approved these changes
Mar 10, 2022
Member
There was a problem hiding this comment.
It is far more common to identify libraries by the version of the source code rather than the time when they are built. I don't see much value in this but I guess it does not hurt either.
It is worth noting that __DATE__ and __TIME__ are updated only when the file is recompiled. If the maker relies on another source file its functionality can still change without a proper update in GetCVS()
Contributor
Author
|
@plexoos , I agree that the date and time of compilation are of quite limited usefulness, but there are (rare) occasions when looking through the nightly test log files it helps us spot a problem. As you noted, other information is generally more relevant; this is just additional information. -Gene |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the CVS tags don't work any longer with the code now sitting in git, the date and time of compilation are still useful pieces of information from this function that are displayed in the log files. Otherwise the date and time of StMaker's compilation are shown for this maker from the inherited function. Additionally, the log files are polluted by a warning message if GetCVS() is not overloaded from StMaker.