Avoid onldb master usage when possible#336
Merged
plexoos merged 3 commits intostar-bnl:mainfrom Apr 8, 2022
Merged
Conversation
genevb
requested review from
akioogawa,
jdbrice,
nigmatkulov,
plexoos and
ullrich-bnl
as code owners
Contributor
|
Thank you, Gene! I totally support your changes. Yes, using master DBs for read-only operations should be avoided in most cases. STAR has plenty of replica DB servers available - these will generally work faster than masters, and will not prevent/block STAR services from inserting data into master DBs. |
plexoos
reviewed
Mar 31, 2022
Member
plexoos
left a comment
plexoos
left a comment
There was a problem hiding this comment.
There are scripts in /StRoot/StFgtPool and /StRoot/StSpinPool that also use onldb.starp.bnl.gov. Why leave them out?
plexoos
approved these changes
Mar 31, 2022
veprbl
approved these changes
Apr 1, 2022
zlchang
approved these changes
Apr 1, 2022
Member
|
Akio and Daniel, if you can take a review on the relevant part that you are the owner, comment/approve the PR? Thanks |
Member
|
Does it make sense to wait for other approvals any longer? |
Member
|
Dmitri, please proceed and merge this PR. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a general sweep of code in the repository to avoid accessing the online master DB unless writing, and possibly use offline replicas if not using code from within the online enclave. People tend to copy existing code when they write new codes and it's best if everyone, old and new, makes a habit of reading from replicas (@dmarkh may wish to comment).
@akioogawa , I also updated some logic you use in StRoot/StFcsFastSimulatorMaker/macro/thresh.pl for determining which backup port to access, so please have a look. You were relying on a Jan. 1st rollover from one database to another, but Oct. 1st is more appropriate.
-Gene