Fix the issues causing FST codes not running#338
Fix the issues causing FST codes not running#338techuan-huang merged 1 commit intostar-bnl:mainfrom techuan-huang:main
Conversation
techuan-huang
requested review from
genevb,
klendathu2k and
plexoos
as code owners
| for(int i = 0; i < 108; i++){ | ||
| memset(&row,0,tableSet->GetRowSize()); | ||
| row.Id = i+1; | ||
| row.Id = i+1000; |
There was a problem hiding this comment.
Could you point to the code where it is used so we can see the problem?
There was a problem hiding this comment.
I'm not sure if somewhere else will be affected, but for what I tested, the problem is in StRoot/StFstHitMaker/StFstHitMaker.cxx:
The database is loaded with StFstDb and the table is assigned to a variable on line 44.
This variable is then used on line 192 for transforming the coordinates of the hit positions.
As defined on line 191, the sensorId should begin with 1000.
There was a problem hiding this comment.
Thank you, Techuan. I added Xu and Zhenyu here to make sure everyone is on the same page.
On a separate note, Xu and Zhenyu, as the PoC of FST are not listed as the code maintainers for StarDb/xxx/fst directory. I feel we may want to specify this, also for other subsystems, so the PRs can automatically pick up the reviewers.
There was a problem hiding this comment.
the sensorId should begin with 1000
Ok, I see that in the corresponding database table these sensor ids start from 1000, so this macro is supposed to follow the same numbering.
There was a problem hiding this comment.
Dmitri, thanks for checking.
Since there are already two reviewers approved, should we go ahead to merge this PR or we need to wait for your approval?
There was a problem hiding this comment.
The formal requirements are met, so merge it anytime
There was a problem hiding this comment.
Thanks, I will click the merge button.
|
|
||
| {"fstFastSim","fstChain","","StMcEvent,StEvent","StFstFastSimMaker","StFstSimMaker","FST fast simulator", | ||
| kFALSE}, | ||
| {"fstRawHit", "", "fstChain", "fstUtil,fstDb","StFstRawHitMaker", "StFstRawHitMaker","FST raw hit maker", | ||
| kFALSE}, | ||
| {"fstCluster", "", "fstChain", "fstRawHit","StFstClusterMaker", "StFstClusterMaker","FST Cluster maker", | ||
| kFALSE}, | ||
| {"fstHit", "", "fstChain", "event,fstCluster", "StFstHitMaker", "StFstHitMaker","FST Hit Maker", | ||
| kFALSE}, | ||
| {"fstUtil" , "", "fstChain", "", "", "StFstUtil", "Fst Utilities", | ||
| kFALSE}, |
genevb
left a comment
genevb
left a comment
There was a problem hiding this comment.
I certainly approve of removing the duplication in BigFullChain.h.
sunxuhit
left a comment
sunxuhit
left a comment
There was a problem hiding this comment.
These changes are already discussed in FST group and verified locally.
5 participants
There are two issues in the current DEV causing FST codes not running.
The first one is StFstUtil not loaded before StFstRawHitMaker in the chain options. The second is the incorrect range of FST sensor id in StarDb geometry.
In order to run FST codes, I made following changes: