Skip to content

Add FST hits in MuDst#341

Merged
jdbrice merged 3 commits intostar-bnl:mainfrom
techuan-huang:main
May 16, 2022
Merged

Add FST hits in MuDst#341
jdbrice merged 3 commits intostar-bnl:mainfrom
techuan-huang:main

Conversation

@techuan-huang
Copy link
Copy Markdown
Contributor

The purpose of this PR is to set up FST hits in MuDst events.

There are 3 additional classes (6 files) for FST was added (StMuFstCollection, StMuFstHit, and StMuFstUtil).
7 files are modified for adding the FST hits (StMuArrays, StMuDst, StMuDstMaker, and StMuTypes).

@starsdong
Copy link
Copy Markdown
Member

Hi experts, could you please take a look at this PR? Comment or approve this PR? To me I see the changes look straightforward and reasonable.

Copy link
Copy Markdown
Contributor

@sunxuhit sunxuhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@starsdong
Copy link
Copy Markdown
Member

Daniel, could you please take a look at this request, comment or approve this so we can include this into the library? Thanks

Copy link
Copy Markdown
Contributor

@jdbrice jdbrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump the version of StMuDst
ClassDef(StMuDst,5) --> ClassDef(StMuDst,6)

@techuan-huang
Copy link
Copy Markdown
Contributor Author

Hi Daniel,
Thanks for the comment. I guess I also need to do this for StMuDstMaker?
ClassDef(StMuDstMaker, 8) --> ClassDef(StMuDstMaker, 9)?

Copy link
Copy Markdown
Contributor

@jdbrice jdbrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates

@jdbrice jdbrice merged commit 1534b05 into star-bnl:main May 16, 2022
@plexoos plexoos added this to the SL22b milestone May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants