Skip to content

adding etof-alignment table#348

Merged
starsdong merged 1 commit intostar-bnl:mainfrom
YannickSoehngen:etof-Db-tables
May 12, 2022
Merged

adding etof-alignment table#348
starsdong merged 1 commit intostar-bnl:mainfrom
YannickSoehngen:etof-Db-tables

Conversation

@YannickSoehngen
Copy link
Copy Markdown
Contributor

New ETof-Detector-Alingment table

@dmarkh
Copy link
Copy Markdown
Contributor

dmarkh commented May 9, 2022

Questions:

a) How's that different from the existing GeomAlign table? Please indicate in the table name or in the description.
https://online.star.bnl.gov/dbExplorer/#Geometry/etof/reconV0/etofGeomAlign

b) New db table requires database initialization in addition to the IDL file. Could you please follow the steps described here:
https://drupal.star.bnl.gov/STAR/comp/db/how-to-user/new-table/

@dmarkh
Copy link
Copy Markdown
Contributor

dmarkh commented May 12, 2022

Okay, the corresponding database structure is now initialized:
https://online.star.bnl.gov/dbExplorer/#Geometry/etof/reconV0/etofAlign

Copy link
Copy Markdown
Contributor

@dmarkh dmarkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@starsdong
Copy link
Copy Markdown
Member

Looks good to me too. Merging.

@starsdong starsdong merged commit 1c29e04 into star-bnl:main May 12, 2022
@plexoos plexoos added this to the SL22b milestone May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants