ci: Add test jobs with doEvents.C from StRoot/macros#374
Merged
plexoos merged 4 commits intostar-bnl:mainfrom Jul 8, 2022
Merged
ci: Add test jobs with doEvents.C from StRoot/macros#374plexoos merged 4 commits intostar-bnl:mainfrom
plexoos merged 4 commits intostar-bnl:mainfrom
Conversation
plexoos
force-pushed
the
pr/run_test_macros
branch
2 times, most recently
from
7c9c9ca to
7c73863
Compare
Member
I'm not sure what it wants here. I've tried throwing the https://github.com/star-bnl/star-sw/blob/main/StRoot/macros/analysis/find_vertex.C into godbolt and it didn't give me any syntax errors (there were other compilation errors of course). |
Member
Author
|
I think I know what it wants... We'll see in #375 |
plexoos
force-pushed
the
pr/run_test_macros
branch
from
7c73863 to
34da6bc
Compare
genevb
reviewed
Jul 8, 2022
Contributor
genevb
left a comment
genevb
left a comment
There was a problem hiding this comment.
find_vertex.C (under a directory I review): I have no objections to the proposed changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.