Skip to content

Add official centrality calibration for 14.6 GeV Run 19#384

Merged
starsdong merged 12 commits intomainfrom
centrality_auau14p6gev
Aug 25, 2022
Merged

Add official centrality calibration for 14.6 GeV Run 19#384
starsdong merged 12 commits intomainfrom
centrality_auau14p6gev

Conversation

@nigmatkulov
Copy link
Copy Markdown
Member

Official centrality calibration for 14.6 GeV Run19. Also added Makefile for standalone package compilation, which should work with ROOT6 (not with ROOT5 because of CINT).

- Add centrality for 14.6 GeV year 2019.
- Fix parameter swap for trigger efficiency calculation.
- Add Param.cxx (in order to compile in a standalone mode)
- Add Makefile to build standalone library (works only with ROOT6)
@starsdong
Copy link
Copy Markdown
Member

Hi Grigory, great to see this PR. I am about to send out the announcement for tomorrow's meeting. Will it be possible that you can give a presentation on this PR tomorrow? Thanks

@nigmatkulov
Copy link
Copy Markdown
Member Author

give a presentation on this PR tomorrow?

Hi Xin, are you talking about the S&C meeting? Do I need to prepare slides?

@starsdong
Copy link
Copy Markdown
Member

Yes, Grigory. I think it will be up to you if you see necessary to show a few slides. Thanks

@nigmatkulov
Copy link
Copy Markdown
Member Author

Yes, Grigory. I think it will be up to you if you see necessary to show a few slides. Thanks

I think I can say a few words about this PR.

Comment thread .github/CODEOWNERS
@plexoos plexoos changed the title Centrality auau14p6gev Add official centrality calibration for 14.6 GeV Run 19 Aug 22, 2022
@nigmatkulov nigmatkulov requested a review from zsweger August 22, 2022 19:29
@starsdong
Copy link
Copy Markdown
Member

Rongrong and Dmitri, shall we merge this PR so users can start to use it in their analysis? Thanks

@marrbnl
Copy link
Copy Markdown
Member

marrbnl commented Aug 23, 2022

OK with me. But I think Grigory wants to have Zach involved and go through the procedure.

@zsweger
Copy link
Copy Markdown
Contributor

zsweger commented Aug 24, 2022

OK with me. But I think Grigory wants to have Zach involved and go through the procedure.

Yep, I'm working on validating the changes and am writing some code to compare the expected performance of StRefMultCorr vs its actual performance. I had hoped to finish today, but it looks like it may take one more day.

@zsweger
Copy link
Copy Markdown
Contributor

zsweger commented Aug 25, 2022

I edited a typo in the event-weight parameters that was giving some events a negative weight. I've tested the pileup rejection, Vz correction, and event weights on real data and they all now perform as expected. I sign off.

@zsweger zsweger closed this Aug 25, 2022
@starsdong
Copy link
Copy Markdown
Member

Zach, we should merge this PR to the main branch. I am going to reopen it and merge it.

@starsdong starsdong reopened this Aug 25, 2022
@starsdong starsdong merged commit 4a51699 into main Aug 25, 2022
@starsdong starsdong deleted the centrality_auau14p6gev branch August 25, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants