Fix memory leaks when MuDst included with FWD data. Introduce a switch for FTT calibration mode (dump values to file)#387
Merged
plexoos merged 6 commits intostar-bnl:mainfrom Aug 30, 2022
Conversation
akioogawa
approved these changes
Aug 27, 2022
starsdong
approved these changes
Aug 27, 2022
plexoos
reviewed
Aug 27, 2022
plexoos
changed the title
plexoos
reviewed
Aug 29, 2022
klendathu2k
approved these changes
Aug 30, 2022
[skip-ci]
plexoos
approved these changes
Aug 30, 2022
Member
plexoos
left a comment
plexoos
left a comment
There was a problem hiding this comment.
Thank you for addressing the comments. Looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Akio found and fixed several memory leaks.
Fwd MuDst data structures (Fst, Ftt, Fcs) were causing memory leaks that could cause crash of BFC due to running out of memory. Memory leaks appeared to happen from StEvent structures, because MuDst code made a copy of StEvent containers.
Update uses const references to avoid any copy and subsequent leak.
Also includes one memory leak fix / small update on StFttHitCalibMaker to prepare for future calibration productions.