Fix GCC warning: forbidden conversion to char*

[plexoos]

GCC 11
warning: ISO C++ forbids converting a string constant to 'char*' [-Wwrite-strings]

GCC 485
warning: deprecated conversion from string constant to 'char*' [-Wwrite-strings]

See #392 for motivation

[veprbl]

Diff LGTM

[plexoos]

Thanks @veprbl @akioogawa It is still a WIP though.
With the fixes in this PR the number of the targeted warnings went down but there is still a lot more to take care of.

--- fix_warns_orig.out  2022-09-03 18:33:15.000000000 -0400
+++ fix_warns_pr.out    2022-09-03 18:33:47.000000000 -0400
@@ -1,6 +1,6 @@
                                                                       msg  count
-0         deprecated conversion from string constant to [-Wwrite-strings]    798
+0         deprecated conversion from string constant to [-Wwrite-strings]    439
 1      may be used uninitialized in this function [-Wmaybe-uninitialized]    425
 2   deleting object of polymorphic class type which has non-virtual de...    403
 3                   variable set but not used [-Wunused-but-set-variable]    341
 4                                     unused variable [-Wunused-variable]    293

[plexoos]

At least these are gone

 msg_id                                                                                                                                    msg
      0                                                                        deprecated conversion from string constant to [-Wwrite-strings]
...

 msg_id                                                                                                                                    msg
...
     16                                                                                               defined but not used [-Wunused-variable]
...
     22                                                                                    too many arguments for format [-Wformat-extra-args]
...

[veprbl]

Good to merge

[plexoos]

@jml985 @tonko-lj I would like to hear your comments as most of the warnings come from your code in StRoot/RTS/ and OnlTools/

[jml985]

There are seem to be three areas here:

1. OnlTools/OnlinePlots --- Nobody cares about these. These were the "Panitkin Plots" that have not been used since 2012 or so.
2. OnlTools/Jevp --- These are mostly my code but run under a close-to-standard offline environment and if they compile they are probably just fine. I'd prefer if you just tell me what you want changed so I can do it, but updating the git directly probably won't cause any harm.
3. StRoot/RTS --- These are the DAQ code we share with offline. Git is not the primary source, so changing it here is just a source of confusion. The code has to work with old VXWORKS compilers so please contact me or Tonko if you want changes made here.

[plexoos]

From the private communication:

On 9/21/22 10:32 AM, Landgraf, Jeffery M. wrote:

Sounds good.

-Jeff

Hi Jeff,

let's not step on each other so I propose I deal with
the DETs (e.g. the DAQ_XXX subdirs) & RTS_EXAMPLE directory,
none which should be used in vxWorks, right?

And you deal with the rest (include files), for now at least?

-- Tonko

On Tue, Sep 20, 2022 at 6:44 PM Landgraf, Jeffery M. wrote:

Ok, I'll check them. Most likely I can do this friday.

-Jeff

Hello,

yeah, I'm also irritated and it is not that hard to change on my end.
I've been pruning my stuff with time. But I also don't know what happens
with vxWorks since I don't use it much anymore.

Jeff, how about you change one/few file to "const char *" and see what happens with
vxWorks? I'm betting it will be fine but...

-- Tonko

[plexoos]

Last call for the code owners to comment or approve