Skip to content

cons: Use mysql_config to set up external dependency for mysql#402

Merged
plexoos merged 3 commits intostar-bnl:mainfrom
plexoos:pr/no_optstar
Oct 2, 2022
Merged

cons: Use mysql_config to set up external dependency for mysql#402
plexoos merged 3 commits intostar-bnl:mainfrom
plexoos:pr/no_optstar

Conversation

@plexoos
Copy link
Copy Markdown
Member

@plexoos plexoos commented Sep 22, 2022

When we configure the build with mysql as external dependency we can fully rely on mysql_config found in PATH

This is similar to #357 where we also use config utilities to set up fastjet and gsl packages.

@plexoos plexoos added the infrastructure Build environment and configuration label Sep 23, 2022
@plexoos plexoos added this to the SL22d milestone Sep 23, 2022
Copy link
Copy Markdown
Contributor

@klendathu2k klendathu2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. Only issue is that if we need to build against a specific mysql install... it needs to be located in the path before /usr/bin/mysql_config. (Presumably managed by spack or ...)

@plexoos
Copy link
Copy Markdown
Member Author

plexoos commented Sep 23, 2022

In case someone wants to use a specific mysql install, the same principle would apply, i.e. they just update/prepend their PATH with the location of their mysql_config. It is not very different from setting an additional variable such as USE_LOCAL_MYSQL

P.S. It is a bit hard to imagine a volunteer who would like to experiment with a new version of mysql client. I think at this moment in STAR history the focus is more on the environment preservation rather than a new R&D... But the possibility is not closed with this update.

@plexoos
Copy link
Copy Markdown
Member Author

plexoos commented Sep 27, 2022

Gene, do you have any objections to the changes?

@genevb
Copy link
Copy Markdown
Contributor

genevb commented Sep 28, 2022

Gene, do you have any objections to the changes?

I don't know enough about this to object to the implementation. I don't have any objections to the idea of enabling flexible handling of mysql dependency as long as people compiling root4star outside of SDCC/RCF don't end up having complications and confusion.

Copy link
Copy Markdown
Contributor

@genevb genevb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No bjections

@plexoos
Copy link
Copy Markdown
Member Author

plexoos commented Sep 28, 2022

Thank you for your feedback. I asked because you are a designated maintainer of this code in mgr/ Of course it can be changed at any time at your will.
If there are any specific concerns with installation of star-sw on a supported system we'll deal with them when details become available.

I'll interpret this response as an approval for these specific changes and in the similar PRs: #402, #404, and #405

@plexoos plexoos merged commit be608cb into star-bnl:main Oct 2, 2022
plexoos added a commit that referenced this pull request Oct 2, 2022
When we configure the build with xml2 as external dependency we can rely
on xml2-config found in PATH

This is similar to #357 where we
also use config utilities to set up fastjet and gsl packages and #402
for mysql

[skip ci]
plexoos added a commit that referenced this pull request Oct 2, 2022
When we configure the build with log4cxx as external dependency we can
rely on pkg-config found in PATH

This is similar to #357 where we
also use config utilities to set up fastjet and gsl packages,
#402 for mysql, and #404 for
xml2
@plexoos plexoos deleted the pr/no_optstar branch October 2, 2022 00:57
@plexoos plexoos modified the milestones: SL22d, SL23a Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure Build environment and configuration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants