[root6] Modify StRoot/StBFChain/BFC.C for ROOT6/cling#423
Merged
veprbl merged 2 commits intostar-bnl:mainfrom Oct 28, 2022
Merged
[root6] Modify StRoot/StBFChain/BFC.C for ROOT6/cling#423veprbl merged 2 commits intostar-bnl:mainfrom
veprbl merged 2 commits intostar-bnl:mainfrom
Conversation
… several things being redefined. It points to this BFC.C macro in StBFChain/. BFC.C is loaded and executed through the ROOT interpreter in StBFChain::Setup. Minimal solution is to protect the table implementation for "Bfc" from being compiled by the cling interpreter (just like it is protected from compilation by the CINT interpreter). Likely solves the same problem which Victor was addressing on the Star6 branch. https://github.com/star-bnl/star-sw/blame/Star6/StRoot/StBFChain/BFC.C#L6
veprbl
approved these changes
Oct 27, 2022
Member
veprbl
left a comment
veprbl
left a comment
There was a problem hiding this comment.
I don't think I've seen this issue, but seems okay
plexoos
approved these changes
Oct 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StRoot/StBFChain/BFC.C is loaded and executed through the ROOT interpreter in StBFChain::Setup.
ROOT 6 / cling complains about redefinitions when we run the bfc macro.
Minimal solution is to protect the table implementation for "Bfc" from being compiled by the cling interpreter (just like it is protected from compilation by the CINT interpreter).
Likely solves the same problem which Victor was addressing on the Star6 branch.
https://github.com/star-bnl/star-sw/blame/Star6/StRoot/StBFChain/BFC.C#L6