Conversation
Member
plexoos
commented
Feb 1, 2023
plexoos
commented
``` git diff SL19b_3..SL23a_0 -- docker/ .github/workflows/ Dockerfile tests/ asps/rexe/Cons* asps/rexe/*LinkDef* mgr/Cons* mgr/config/ StRoot/macros/rootlogo*.C StRoot/macros/.rootrc > patch.diff git am < patch.diff ```
Since this is done manually for the the generated classes (`StarGeometry` and `Geometry`), we need to turn off the automatic dictionary generation in `StarVMC/Geometry` triggered otherwise by the `StarGeoLinkDef.h` file. cherry-pick 8378339
StRoot/RTS/EventTracker See 248c020: Remove obscure package pams/sim/g2r
plexoos
force-pushed
the
pr/backport_ci_SL19b
branch
from
4bae249 to
2cc2cd3
Compare
Member
Author
|
This PR seemed to pass the tests as expected, although one test job 101 crashed on the first attempt and succeeded on the second try. I don't like to see such instabilities but there is no time to investigate right now so, I am going to merge and restart #481 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.