run by run v3 with font removed#526
Conversation
ssedd1123
requested review from
marrbnl,
nigmatkulov and
zsweger
as code owners
|
Any comment from your side, Grigory and Zach? Thanks |
|
|
||
| To install the software, follow these steps: | ||
| The EASY way (Linux only. For Windows and Mac, use the recommended way): | ||
| 1. Run the following command: `python3 -m pip install --user matplotlib ruptures pandas numpy scipy pyfiglet uproot scikit-learn` |
There was a problem hiding this comment.
Usually it helps to freeze the dependencies in requirements.txt (or in pyproject.toml). It should help with reproducibility of results as well.
There was a problem hiding this comment.
I have updated my repo to include requirements.txt for Linux. For some reasons the packages must be installed with anaconda on Windows so I don't have one for Windows.
I have also updated my run-by-run code to include a legacy mode to emulate the behavior of the old version (v2).
There was a problem hiding this comment.
The requirements.txt file is platform-agnostic and used by Python package managers to establish dependencies in virtual environments. However, it seems to have been left out of this particular pull request.
There was a problem hiding this comment.
I tried to use requirements.txt on my Windows desktop and Windows laptop with pip3 install -r requirements.txt and the package "rupture" gives me errors. Something along the line of "error: Microsoft Visual C++ 14.0 or greater is required. Get it with "Microsoft C++ Build Tools"". I did update my Microsoft C++ Build Tools but it's still not working. I can still get that particular package to work on Windows, but only if I install with conda, i.e. conda install ruptures.
However, this requirements.txt definitely works on RCAS.
…he behavior of run-by-run v2.
|
@plexoos Hello Dmitri. This pull request has been approved by two people, so I think it is ready to be merged. Since I have not done this before, should I click "Squash and merge" or something else?Thanks. |
|
Rongrong, yes. Generally, I would wait for the CI build and test jobs to finish successfully. Then the "Squash and merge" button will turn green. I guess it is not relevant for this PR anyway. We can merge now if it is urgent or wait for the rest to finish. |
|
Thanks for the clarification, Xin. We can wait for the test to finish. |
4 participants
It should be pure python code now.