Conversation
plexoos
requested review from
genevb,
klendathu2k and
nigmatkulov
as code owners
[pkg] vc: Export package prefix instead of Vc_LIB_DIR [env] Fix 588a489e. Order of requested packages matters [env] Disable view for container setups
[env] Install fastjet for StRoot/StJetFinder in star-sw [pkg] Add some ROOT dependencies to LD_LIBRARY_PATH in star-env [pkg] Add ROOT to LD_LIBRARY_PATH via star-env [pkg] Introduce second Vc version via star-env [pkg] Add Vc as dependency to star-env package
Member
Author
|
Tried to merge the current main into this but found that it is much easier to deal with the conflicts by rebasing instead |
veprbl
reviewed
Aug 5, 2021
veprbl
approved these changes
Aug 5, 2021
Member
veprbl
left a comment
veprbl
left a comment
There was a problem hiding this comment.
It's a big changeset, but only affects CI. Diff LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.