Skip to content

ci: Run build action on all pushes and pull requests to any branch#91

Merged
plexoos merged 1 commit intostar-bnl:mainfrom
veprbl:pr/always_ci
Aug 10, 2021
Merged

ci: Run build action on all pushes and pull requests to any branch#91
plexoos merged 1 commit intostar-bnl:mainfrom
veprbl:pr/always_ci

Conversation

@veprbl
Copy link
Copy Markdown
Member

@veprbl veprbl commented Aug 10, 2021

It doesn't make sense to treat non-main branch PR's specially.

It's also desirable to run actions on direct-pushed tags and we also want users to be able to run CI in their forks before creating the PR.

It doesn't make sense to treat non-main branch PR's specially.

It's also desirable to run actions on direct-pushed tags and we also
want users to be able to run CI in their forks before creating the PR.
Copy link
Copy Markdown
Member

@plexoos plexoos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is fine

@plexoos plexoos changed the title ci: run build action on all pushes and pull requests to any branch ci: Run build action on all pushes and pull requests to any branch Aug 10, 2021
@plexoos plexoos merged commit c25a2fd into star-bnl:main Aug 10, 2021
@plexoos
Copy link
Copy Markdown
Member

plexoos commented Aug 10, 2021

Hm, the number of jobs doubles: #93 Now we have jobs triggered from push and pull_request events?

@veprbl
Copy link
Copy Markdown
Member Author

veprbl commented Aug 10, 2021

Strange. IIRC this is unlike on travis or on gitlab-ci that would not spawn a separate build.

Maybe use https://github.com/marketplace/actions/skip-duplicate-actions ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants