Skip to content

[VET-2546] **Breaking Change** Do not flatten request body nor unflatten response body for db.options#283

Merged
joshhk72 merged 3 commits intomasterfrom
bug/VET-2545-dont-unflat-properties
Oct 11, 2022
Merged

[VET-2546] **Breaking Change** Do not flatten request body nor unflatten response body for db.options#283
joshhk72 merged 3 commits intomasterfrom
bug/VET-2545-dont-unflat-properties

Conversation

@joshhk72
Copy link
Copy Markdown
Contributor

@joshhk72 joshhk72 commented Oct 11, 2022

@joshhk72 joshhk72 changed the title [VET-2545] Don't unflatten properties for db.options [VET-2546] Don't unflatten properties for db.options Oct 11, 2022
@anneeb anneeb changed the title [VET-2546] Don't unflatten properties for db.options [VET-2546] **Breaking Change** Don't unflatten properties for db.options Oct 11, 2022
@anneeb anneeb changed the title [VET-2546] **Breaking Change** Don't unflatten properties for db.options [VET-2546] **Breaking Change** Do not flatten request body nor unflatten response body for db.options Oct 11, 2022
Copy link
Copy Markdown
Contributor

@anneeb anneeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@SpiralP SpiralP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

insane to me that get() uses PUT and acts like getAll()/GET but is filtered to what you pass it

looks good to me!

@SpiralP SpiralP assigned joshhk72 and unassigned SpiralP and anneeb Oct 11, 2022
@joshhk72 joshhk72 merged commit c7c5545 into master Oct 11, 2022
@joshhk72 joshhk72 deleted the bug/VET-2545-dont-unflat-properties branch October 11, 2022 20:40
@joshhk72 joshhk72 modified the milestones: v3.6.0, v4.4.0 Oct 11, 2022
@anneeb anneeb modified the milestones: v3.6.0, v4.4.0 Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants