[VET-5756] feat: add support for fetching endpoint log archive#313
Merged
[VET-5756] feat: add support for fetching endpoint log archive#313
Conversation
jakehamilton
requested review from
SpiralP,
anneeb,
joshhk72 and
mysticfalconvt
as code owners
SpiralP
reviewed
Jul 11, 2025
jakehamilton
commented
Jul 11, 2025
| /** | ||
| * Retrieves a zip file containing log information for an endpoint. | ||
| */ | ||
| function logs(conn: Connection): Promise<Response>; |
Contributor
Author
There was a problem hiding this comment.
Decided to use a plain Response object here instead of returning a Blob or ArrayBuffer to give the consumer the freedom to handle that as they see fit. Some use cases might be easier as one or the other and they're accessed simply enough from the response object like normal:
const blob = await stardog.server.logs().blob()
// or
const buffer = await stardog.server.logs().arrayBuffer()
SpiralP
reviewed
Jul 11, 2025
SpiralP
approved these changes
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VET-5756