Conversation
SpiralP
requested review from
anneeb,
jakehamilton,
joshhk72 and
mysticfalconvt
as code owners
jakehamilton
approved these changes
Nov 11, 2025
Contributor
jakehamilton
left a comment
jakehamilton
left a comment
There was a problem hiding this comment.
Thank you for the fix :)
|
|
||
| const testConnection = (conn, connectionOptions) => { | ||
| const headers = conn.headers(); | ||
| headers.set('Content-Type', 'text/turtle'); |
Contributor
There was a problem hiding this comment.
Should this change back to text/turtle when we eventually revert or is this call supposed to be json always?
Member
Author
There was a problem hiding this comment.
oh yea, fixed a bug here
below there is a:
// connectionOptions is a JSON object made up of properties of metadata provider parameters and their values in Turtle syntax
body: JSON.stringify(connectionOptions),and it's used like this in another app:
testConnection: createStardogAsyncThunk<{
connectionOptions: Record<string, string>;
}>('providers/testConnection', ({ connection, connectionOptions }) =>
stardogCatalog.testConnection(connection, connectionOptions)
),so it seems to be a json object of Record<string, string> (i think turtle was a mistake)
Member
Author
There was a problem hiding this comment.
i should also mention i did test this, and both application/json and text/turtle give the same result with the same input
reading stardog code, it seems to do JSON.parse(...).getAsJsonObject() first as well
anneeb
approved these changes
Nov 18, 2025
anneeb
deleted the
VET-6222-investigate-and-fix-issue-with-special-characters-in-questions
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VET-6222