fix: add missing ndarray test fixture#1054
Conversation
stdlib-bot
left a comment
There was a problem hiding this comment.
🎉 Welcome! 🎉
And thank you for opening your first pull request! We will review it shortly. 🏃 💨
|
Backstory: I was looking at using stdlib ndarray but saw the "test: failing" CI badge at https://github.com/stdlib-js/ndarray, which gave me pause. I'm not sure if this is all that's needed to fix the tests. Also, I copied the code from https://github.com/stdlib-js/stdlib/blob/develop/lib/node_modules/%40stdlib/ndarray/dispatch/test/fixtures/fill.js. It seems to me like maybe |
Ah! Unless you need the entire namespace, I suggest using the individual packages. E.g., $ npm install @stdlib/ndarray-arrayThe omission of the fixture file is my fault. I believe I have it on another dev machine. Let me circle back.
Indeed. The main thing holding this up is implementing the C kernel, which we haven't had the bandwidth to address. For the test fixtures, it's fine if these implementations are not optimal, as we don't care as much about raw perf, but they aren't really appropriate as general packages. We do have lower-level implementations which do implement kernels (e.g., |
kgryte
left a comment
There was a problem hiding this comment.
I, indeed, had failed to commit this file. The implementation matches the uncommitted file. Will merge in order to resolve failing builds.
|
Thanks, @rotu! |
Description
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers