feat: add c implementation of stats/base/dists/rayleigh/cdf#3931
Merged
Planeshifter merged 5 commits intostdlib-js:developfrom Dec 16, 2024
Merged
feat: add c implementation of stats/base/dists/rayleigh/cdf#3931Planeshifter merged 5 commits intostdlib-js:developfrom
stats/base/dists/rayleigh/cdf#3931Planeshifter merged 5 commits intostdlib-js:developfrom
Conversation
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
stats/base/dists/rayleigh/cdfstats/base/dists/rayleigh/cdf
Vinit-Pandit
commented
Dec 15, 2024
…clude/stdlib/stats/base/dists/rayleigh/cdf.h Signed-off-by: Vinit Pandit <106718914+MeastroZI@users.noreply.github.com>
Planeshifter
requested changes
Dec 15, 2024
Member
Planeshifter
left a comment
There was a problem hiding this comment.
Thanks for your work! Left a bunch of comments that should be addressed, but otherwise this PR is looking good.
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Signed-off-by: Vinit Pandit <106718914+MeastroZI@users.noreply.github.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
approved these changes
Dec 16, 2024
Member
Planeshifter
left a comment
There was a problem hiding this comment.
Thanks for your edits! Will merge once CI has passed.
Contributor
PR Commit MessagePlease review the above commit message and make any necessary adjustments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3798 .
Description
This pull request:
stats/base/dists/rayleigh/cdfRelated Issues
This pull request:
@stdlib/stats/base/dists/rayleigh/cdf#3798Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers