refactor: replace built-ins by stdlib packages, update benchmarks in `math/base/special/trunc` by gunjjoshi · Pull Request #3941 · stdlib-js/stdlib

gunjjoshi · 2024-12-16T05:39:26Z

Description

What is the purpose of this pull request?

This pull request:

replaces the use of math.h in the C implementation of math/base/special/trunc by using stdlib_base_ceil and stdlib_base_floor, similar to the JS implementation.
updates examples, benchmarks, manifest.json and tests to follow latest conventions.
renames trunc.c to main.c.

Related Issues

Does this pull request have any related issues?

None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

stdlib-bot · 2024-12-16T05:41:35Z

Coverage Report

Package	Statements	Branches	Functions	Lines
math/base/special/trunc	$\color{green}201/201$ $\color{green}+100.00\%$	$\color{green}7/7$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}201/201$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Signed-off-by: Athan <kgryte@gmail.com>

kgryte · 2024-12-18T09:51:42Z

 {
  "options": {
-    "task": "build",
-    "wasm": false


@gunjjoshi Don't delete the wasm fields or configuration. These were added intentionally in preparation for future WebAssembly builds.

Oh, sorry for that, I've reverted the changes, thanks!

kgryte

Thanks for working on this @gunjjoshi. Apart from the manifest.json, this PR looks good.

Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>

Planeshifter

LGTM.

stdlib-bot · 2024-12-18T14:26:17Z

PR Commit Message

refactor: replace built-ins by stdlib packages, update benchmarks in `math/base/special/trunc`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3941

Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>

Please review the above commit message and make any necessary adjustments.

…`math/base/special/trunc` PR-URL: stdlib-js#3941 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com> Signed-off-by: Athan Reines <kgryte@gmail.com> Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com> --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

…`math/base/special/trunc` PR-URL: stdlib-js#3941 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com> Signed-off-by: Athan Reines <kgryte@gmail.com> Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com> --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: ---

…`math/base/special/trunc` PR-URL: stdlib-js#3941 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com> Signed-off-by: Athan Reines <kgryte@gmail.com> Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com> --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

…`math/base/special/trunc` PR-URL: stdlib-js#3941 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com> Signed-off-by: Athan Reines <kgryte@gmail.com> Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com> --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: ---

gunjjoshi added 2 commits December 16, 2024 10:57

refactor: replace built-ins by stdlib packages

e82178c

docs: update function name

af67bc0

stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Dec 16, 2024

kgryte added 2 commits December 18, 2024 01:49

docs: update example

02b86ee

Signed-off-by: Athan <kgryte@gmail.com>

docs: update example

2391b7a

Signed-off-by: Athan <kgryte@gmail.com>

kgryte reviewed Dec 18, 2024

View reviewed changes

kgryte requested changes Dec 18, 2024

View reviewed changes

kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 18, 2024

Update manifest.json

94055a3

Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>

Planeshifter approved these changes Dec 18, 2024

View reviewed changes

Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 18, 2024

stdlib-bot removed the Needs Changes Pull request which needs changes before being merged. label Dec 18, 2024

Planeshifter merged commit 8785e54 into stdlib-js:develop Dec 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor: replace built-ins by stdlib packages, update benchmarks in `math/base/special/trunc`#3941

refactor: replace built-ins by stdlib packages, update benchmarks in `math/base/special/trunc`#3941
Planeshifter merged 5 commits intostdlib-js:developfrom
gunjjoshi:trunc

gunjjoshi commented Dec 16, 2024

Uh oh!

stdlib-bot commented Dec 16, 2024 •

edited

Loading

Uh oh!

kgryte Dec 18, 2024

Uh oh!

gunjjoshi Dec 18, 2024

Uh oh!

kgryte left a comment

Uh oh!

Planeshifter left a comment

Uh oh!

stdlib-bot commented Dec 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

gunjjoshi commented Dec 16, 2024

Description

Related Issues

Questions

Other

Checklist

Uh oh!

stdlib-bot commented Dec 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

kgryte Dec 18, 2024

Choose a reason for hiding this comment

Uh oh!

gunjjoshi Dec 18, 2024

Choose a reason for hiding this comment

Uh oh!

kgryte left a comment

Choose a reason for hiding this comment

Uh oh!

Planeshifter left a comment

Choose a reason for hiding this comment

Uh oh!

stdlib-bot commented Dec 18, 2024

PR Commit Message

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

stdlib-bot commented Dec 16, 2024 •

edited

Loading