feat: add C implementation for dist/triangular/median#4004
Merged
Planeshifter merged 5 commits intostdlib-js:developfrom Dec 20, 2024
Merged
feat: add C implementation for dist/triangular/median#4004Planeshifter merged 5 commits intostdlib-js:developfrom
dist/triangular/median#4004Planeshifter merged 5 commits intostdlib-js:developfrom
Conversation
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
dist/triangular/median
Planeshifter
requested changes
Dec 18, 2024
Member
Planeshifter
left a comment
There was a problem hiding this comment.
Thanks for your work!
Left a few comments that will need to be addressed before this PR can be merged; hopefully should be quick to rectify.
…in triangular median examples and benchmarks
Contributor
Author
Done with the changes. Please review. |
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
approved these changes
Dec 20, 2024
Member
Planeshifter
left a comment
There was a problem hiding this comment.
Thanks for making the edits! Will merge shortly after CI is all green.
Contributor
PR Commit MessagePlease review the above commit message and make any necessary adjustments. |
ShabiShett07
pushed a commit
to ShabiShett07/stdlib
that referenced
this pull request
Feb 26, 2025
PR-URL: stdlib-js#4004 Closes: stdlib-js#3817 Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com> Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3817
Description
This pull request:
@stdlib/stats/base/dists/triangular/median#3817Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers