Skip to content

Fix: Add files that are not tracked yet#17

Merged
stefanzweifel merged 2 commits intostefanzweifel:masterfrom
localheinz:fix/diff
Nov 22, 2019
Merged

Fix: Add files that are not tracked yet#17
stefanzweifel merged 2 commits intostefanzweifel:masterfrom
localheinz:fix/diff

Conversation

@localheinz
Copy link
Copy Markdown
Contributor

This PR

  • adds files first, then checks if there's a change

Fixes #16.

Copy link
Copy Markdown
Owner

@stefanzweifel stefanzweifel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Thanks for your contribution. Will tag a release in the next days.

@stefanzweifel stefanzweifel merged commit 284d0b7 into stefanzweifel:master Nov 22, 2019
@localheinz localheinz deleted the fix/diff branch November 23, 2019 00:54
@localheinz
Copy link
Copy Markdown
Contributor Author

Thank you, @stefanzweifel!

@stefanzweifel
Copy link
Copy Markdown
Owner

I'm sorry. I had to revert the changes in fb3de05.

While testing the action in a test project of mine, the action didn't commit changes of existing files. It seems git diff --quiet --staged returns false for changes in existing files and doesn't execute git push.

I will see, how I can implement this without breaking the existing feature set. (Maybe I can somehow add a test suite with bats 🤔)

If you have any suggestions, feel free to mention them here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Untracked files are not committed

2 participants