Skip to content

feat: add Indonesian (Bahasa Indonesia) localization#1513

Merged
steipete merged 2 commits into
steipete:mainfrom
StevanusPangau:feat/indonesian-localization
Jun 15, 2026
Merged

feat: add Indonesian (Bahasa Indonesia) localization#1513
steipete merged 2 commits into
steipete:mainfrom
StevanusPangau:feat/indonesian-localization

Conversation

@StevanusPangau

Copy link
Copy Markdown
Contributor

Summary

Adds native Indonesian (id) as a first-class language, integrated into CodexBar's existing localization system.

  • id.lproj/Localizable.strings — all strings translated into native, idiomatic Indonesian. Format specifiers (%@, %d, %1$@…) and \(name) interpolation placeholders are preserved exactly.
  • Registered id in the AppLanguage enum + Settings → Language picker.
  • Added the localized "language_indonesian" name to the English catalog.
  • Extended LocalizationLanguageCatalogTests parity list.
  • Updated CHANGELOG.md with the new language entry.

No changes were needed to Localization.swift or Package.swift (.process("Resources") auto-bundles the new catalog).

Using it

Selectable as Bahasa Indonesia in Settings → Language (requires app restart). In the default System mode it is now picked up automatically for users whose macOS language is Indonesian.

Verification

  • plutil -lint passes on both .strings files (English and Indonesian).
  • ✅ App builds and Indonesian language appears in Settings → General → Language dropdown.
  • ✅ UI displays Indonesian translations when the language is selected.
  • ✅ Localization catalog test extended to include Indonesian.

Notes

This is my first contribution to this repository. I followed the established localization pattern used by prior language PRs (Korean #1460, Vietnamese #1247, Ukrainian #1250).

@clawsweeper

clawsweeper Bot commented Jun 14, 2026

Copy link
Copy Markdown

Codex review: needs maintainer review before merge. Reviewed June 15, 2026, 1:00 AM ET / 05:00 UTC.

Summary
The PR adds Indonesian localization support with a new id.lproj catalog, language picker registration, labels in existing catalogs, localization tests, smoke coverage, and a changelog note.

Reproducibility: not applicable. this is a feature PR adding a new language rather than a bug reproduction. Current main lacks Indonesian, while the contributor screenshots show the after-change Settings and menu UI path.

Review metrics: 3 noteworthy metrics.

  • Changed files: 21 files, 1161 additions, 2 deletions. The line count is large, but nearly all change is a new localization catalog and one-key additions across existing catalogs.
  • Localization surface: 1 new catalog, 16 existing catalog labels, 2 test files changed. The picker label must exist in every current language for the new language to display consistently.
  • Runtime proof: 3 downloaded screenshots inspected from 5 posted. The inspected images show the after-change Settings language selection and Indonesian-rendered UI.

Merge readiness
Overall: 🐚 platinum hermit
Proof: 🦞 diamond lobster ✨ media proof bonus
Patch quality: 🐚 platinum hermit
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

  • [P2] Have a maintainer or native Indonesian speaker spot-check high-traffic strings before merge.

Risk before merge

  • [P1] Translation quality cannot be independently guaranteed from source inspection alone; a maintainer or native Indonesian speaker should spot-check high-traffic strings before merge.
  • [P1] This read-only review did not run make check or Swift tests; the PR reports validation and the visible GitGuardian check is green.

Maintainer options:

  1. Decide the mitigation before merge
    Land the focused Indonesian localization after normal maintainer/native-speaker review and validation.
  2. Pause or close
    Do not merge this PR until maintainers decide whether the risk is worth taking.

Next step before merge

  • [P2] No repair lane is needed because no concrete patch defect was found; the remaining action is maintainer/native-speaker review plus normal validation.

Security
Cleared: The diff only changes localization resources, an enum registration, tests, and release-note text; no security or supply-chain sensitive behavior changed.

Review details

Best possible solution:

Land the focused Indonesian localization after normal maintainer/native-speaker review and validation.

Do we have a high-confidence way to reproduce the issue?

Not applicable; this is a feature PR adding a new language rather than a bug reproduction. Current main lacks Indonesian, while the contributor screenshots show the after-change Settings and menu UI path.

Is this the best way to solve the issue?

Yes; the implementation follows the existing localization pattern with an enum case, bundled resource catalog, cross-catalog picker labels, and focused tests. The only remaining review gap is translation quality, which is best handled by maintainer or native-speaker spot check.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against 3b5f5234c9fa.

Label changes

Label justifications:

  • P3: This is a low-risk localization feature with limited blast radius and no evidence of a runtime regression.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🦞 diamond lobster and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Sufficient (screenshot): Contributor screenshots show the after-change Settings language selection and Indonesian-rendered app/menu UI, which is sufficient real behavior proof for this visible localization change.
  • proof: sufficient: Contributor real behavior proof is sufficient. Contributor screenshots show the after-change Settings language selection and Indonesian-rendered app/menu UI, which is sufficient real behavior proof for this visible localization change.
  • proof: 📸 screenshot: Contributor real behavior proof includes screenshot evidence. Contributor screenshots show the after-change Settings language selection and Indonesian-rendered app/menu UI, which is sufficient real behavior proof for this visible localization change.
Evidence reviewed

What I checked:

Likely related people:

  • steipete: Current blame for the language picker and localization bundle code points to recent main/release commits by Peter Steinberger, and the PR branch also includes a release-note commit from this handle. (role: recent area contributor; confidence: high; commits: 9d3c354df9ba, e6cbfc134278, 2cd2138212ba; files: Sources/CodexBar/PreferencesGeneralPane.swift, Sources/CodexBar/Localization.swift, Tests/CodexBarTests/LocalizationLanguageCatalogTests.swift)
  • Yuxin-Qiao: Recent merged Italian and Vietnamese localization work touched the same AppLanguage, catalog, and tests surface that this PR extends. (role: adjacent localization contributor; confidence: high; commits: 3b5f5234c9fa, b44218352c43; files: Sources/CodexBar/PreferencesGeneralPane.swift, Sources/CodexBar/Resources/it.lproj/Localizable.strings, Sources/CodexBar/Resources/vi.lproj/Localizable.strings)
  • jack24254029: Merged popup/provider localization work established broader localized UI coverage and tests that this new language relies on. (role: localization infrastructure contributor; confidence: medium; commits: ff2fc132a2da; files: Sources/CodexBar/Localization.swift, Sources/CodexBar/Resources/en.lproj/Localizable.strings)
  • soohanpark: The merged Korean localization is a close precedent cited by this PR and used the same first-class language catalog and picker integration pattern. (role: recent localization contributor; confidence: medium; commits: 0cdc16756bb7, 3fdb549a1215; files: Sources/CodexBar/PreferencesGeneralPane.swift, Sources/CodexBar/Resources/ko.lproj/Localizable.strings, Tests/CodexBarTests/LocalizationLanguageCatalogTests.swift)
  • ykarateke: The merged Turkish localization added a new .lproj catalog, language enum registration, existing-catalog labels, and tests in the same area. (role: adjacent localization contributor; confidence: medium; commits: 186c6de6678a; files: Sources/CodexBar/PreferencesGeneralPane.swift, Sources/CodexBar/Resources/tr.lproj/Localizable.strings, Tests/CodexBarTests/LocalizationLanguageCatalogTests.swift)
What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

@StevanusPangau StevanusPangau force-pushed the feat/indonesian-localization branch from ff38e4e to d84f77c Compare June 14, 2026 05:04
@clawsweeper clawsweeper Bot added rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. labels Jun 14, 2026
@StevanusPangau

Copy link
Copy Markdown
Contributor Author

Runtime proof

Freshly built app with Indonesian selected:

Settings → General → Language picker showing "Bahasa Indonesia":

Screenshot 2026-06-14 at 11 51 49 Screenshot 2026-06-14 at 11 52 19 Screenshot 2026-06-14 at 11 52 35 Screenshot 2026-06-14 at 11 52 55

Menu bar / UI rendered in Indonesian:

Screenshot 2026-06-14 at 11 51 31

Verification

  • plutil -lint passes on id.lproj/Localizable.strings
  • ✅ App builds successfully and Indonesian appears in the language picker
  • ✅ UI renders Indonesian translations after selecting Bahasa Indonesia and restarting
  • ✅ Localization catalog tests extended to include Indonesian

@clawsweeper re-review

@clawsweeper

clawsweeper Bot commented Jun 14, 2026

Copy link
Copy Markdown

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

Re-review progress:

@clawsweeper clawsweeper Bot added proof: sufficient Contributor real behavior proof is sufficient. proof: 📸 screenshot Contributor real behavior proof includes screenshot evidence. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. and removed rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. labels Jun 14, 2026
StevanusPangau and others added 2 commits June 15, 2026 00:50
Add native Indonesian (id) as a first-class language:
- id.lproj/Localizable.strings with all strings translated to native
  Indonesian (placeholders/format specifiers preserved)
- Register `indonesian` in the AppLanguage enum + Settings language picker
- Add the localized "language_indonesian" name to en.lproj
- Extend LocalizationLanguageCatalogTests parity list
@steipete steipete force-pushed the feat/indonesian-localization branch from d84f77c to 2cd2138 Compare June 15, 2026 04:53
@steipete steipete merged commit a174d17 into steipete:main Jun 15, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. proof: 📸 screenshot Contributor real behavior proof includes screenshot evidence. proof: sufficient Contributor real behavior proof is sufficient. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants