docs(output-target): custom elements auto-define export behavior#916
Merged
rwaskiewicz merged 4 commits intov3.0.0-devfrom Sep 19, 2022
Merged
Conversation
This commit updates `autoDefineCustomElements` from being a standalone config flag to an option on `customElementsExportBehavior`
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rwaskiewicz
reviewed
Sep 19, 2022
| | ----------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | ||
| | `default` | No additional re-export or auto-definition behavior will be performed.<br><br>This value will be used if no explicit value is set in the config, or if a given value is not a valid option. | | ||
| | `single-export-module` | All component and custom element definition helper functions will be exported from the `index.js` file in the output directory (see [Defining Exported Custom Elements](#defining-exported-custom-elements) for more information on this file's purpose). This file can be used as the root module when distributing your component library, see [below](#distributing-custom-elements) for more details. | | ||
| | `auto-define-custom-elements` | A component and its children will be automatically defined with the `CustomElementRegistry` when the component's module is imported. | |
Member
There was a problem hiding this comment.
Does it make sense for us to order this alphabetically? I'm kind of on the fence here, since "default" is kind of a special value and I don't know if I'd prefer to differentiate it here by having it at the top. I suppose that doesn't prevent us from doing something like
- default
- auto-define-custom-elements
- single-export-module
At the same time, there's really nothing wrong with
- auto-define-custom-elements
- default
- single-export-module
either. Thoughts?
Contributor
Author
There was a problem hiding this comment.
I like keeping default at the top, but alphabetizing the others makes sense.
14 tasks
rwaskiewicz
requested changes
Sep 19, 2022
Member
There was a problem hiding this comment.
Sorry missed this the first time around (and GH won't let me comment inline) - can you update the type definition above the table to include 'auto-define-custom-elements'?
- customElementsExportBehavior: 'default' | 'single-export-module',
+ customElementsExportBehavior: 'default' | 'auto-define-custom-elements' | 'single-export-module',
rwaskiewicz
approved these changes
Sep 19, 2022
rwaskiewicz
deleted the
docs/v3-custom-elements-auto-define-export-behavior
branch
rwaskiewicz
pushed a commit
that referenced
this pull request
Jan 20, 2023
This commit updates `autoDefineCustomElements` from being a standalone config flag to an option on `customElementsExportBehavior`. This commit is associated with stenciljs/core#3615
rwaskiewicz
pushed a commit
that referenced
this pull request
Jan 23, 2023
This commit updates `autoDefineCustomElements` from being a standalone config flag to an option on `customElementsExportBehavior`. This commit is associated with stenciljs/core#3615
rwaskiewicz
pushed a commit
that referenced
this pull request
Jan 25, 2023
This commit updates `autoDefineCustomElements` from being a standalone config flag to an option on `customElementsExportBehavior`. This commit is associated with stenciljs/core#3615
rwaskiewicz
pushed a commit
that referenced
this pull request
Jan 25, 2023
This commit updates `autoDefineCustomElements` from being a standalone config flag to an option on `customElementsExportBehavior`. This commit is associated with stenciljs/core#3615
rwaskiewicz
pushed a commit
that referenced
this pull request
Jan 25, 2023
This commit updates `autoDefineCustomElements` from being a standalone config flag to an option on `customElementsExportBehavior`. This commit is associated with stenciljs/core#3615
rwaskiewicz
pushed a commit
that referenced
this pull request
Jan 25, 2023
This commit updates `autoDefineCustomElements` from being a standalone config flag to an option on `customElementsExportBehavior`. This commit is associated with stenciljs/core#3615
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates
autoDefineCustomElementsfrom being a standalone config flag to an option oncustomElementsExportBehavior