You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The downside of this approach is that if we wanted to skip both reading and writing then we'd need to implement both functions or have a third function just called skip, but having three separate functions complicates the internals of Glaze.
The second option is to make the skip function templated on whether it is a read or write:
I think having one function is better, but the issue with the template arguments that I see is that user has to see it all the time, I personally would try to add an additional argument to the function aka "context" which the user can use it to figure out if this is a read/write or something else, furthermore the context can be easily extendable
@Yaraslaut, I implemented a new meta_context that is passed to the skip function. Right now it just provides information about whether the operation is parsing or serializing, but more meta information could be added in the future, as per your suggestion. Thanks for recommending this, I think it's a great approach! I also implemented support for skipping when reading.
Thanks for the documentation, i also think that this is a great approach :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Yaraslaut, when creating documentation for this new skip functionality, I realized that what we implemented only currently affects writing.
Skipping can also apply to reading. And, I think in some cases we want to only skip writing or only skip reading.
Here are the two approaches I'm thinking of taking.
First option is to simply name the function
skip_writeand askip_readcould be added later.The second option is to make the skip function templated on whether it is a read or write:
I'm leaning towards this second option. What are your thoughts?