Add Boost.Asio workflow#1887
Conversation
- Create glz_asio target that links Boost.Asio if it's found, or downloads standalone asio - Update all networking tests to use glz_asio
|
One of the tests failed and fuzzing failed to link but I'm not sure why. |
|
Why are you only testing with CLang? |
Two reasons mainly:
It wouldn't be too much work to add gcc. |
Well, I believe this should be tested against everything Glaze is currently tested against - so GCC, clang and MSVC. I can submit a commit if you wish. |
|
Thanks for this pull request! This will allow us to validate that boost-asio is still supported. Others or myself can make the required changes to get everything passing. The threading test occasionally fails with GitHub Actions. I need to spend more time to figure out why, but on my local machine I could not replicate the issue, so I think it is affected by the virtual environment. I'm going to have to figure out a debug workflow via codespaces I think. But, for now it can be ignored. |
|
I'll work on this again soon. |
|
One of the tests failed for f467d24. @admin check logs https://download.copr.fedorainfracloud.org/results/packit/stephenberry-glaze-1887/fedora-rawhide-s390x/09546192-glaze/builder-live.log, packit dashboard https://dashboard.packit.dev/jobs/copr/2776161 and external service dashboard https://copr.fedorainfracloud.org/coprs/build/9546192/ |
|
One of the tests failed for 932c813. @admin check logs None, packit dashboard https://dashboard.packit.dev/jobs/srpm/467534 and external service dashboard https://copr.fedorainfracloud.org/coprs/build/9546385/ |
|
I have updated the workflow to test with multiple versions of clang (17, 18, 20) and gcc (12, 13, 14), each against two different Boost versions (1.88.0 and 1.73.0). |
|
This looks good, thanks for the CMake cleanup! Give me the thumbs up and I'll merge it in. |
|
You can merge this :) |
|
Thanks so much for your work on this! |
Fixes #1883