Skip to content

Add Boost.Asio workflow#1887

Merged
stephenberry merged 10 commits intostephenberry:mainfrom
azais-corentin:boost-asio-workflow
Sep 15, 2025
Merged

Add Boost.Asio workflow#1887
stephenberry merged 10 commits intostephenberry:mainfrom
azais-corentin:boost-asio-workflow

Conversation

@azais-corentin
Copy link
Copy Markdown
Contributor

@azais-corentin azais-corentin commented Aug 8, 2025

Fixes #1883

@azais-corentin
Copy link
Copy Markdown
Contributor Author

One of the tests failed and fuzzing failed to link but I'm not sure why.
Could you take a look @stephenberry ?

@DockedFerret800
Copy link
Copy Markdown
Contributor

Why are you only testing with CLang?

@azais-corentin
Copy link
Copy Markdown
Contributor Author

Why are you only testing with CLang?

Two reasons mainly:

  • I thought the workflows were a bit of mess so I didn't want to touch them too much 😄
  • Since we're only testing standalone vs boost asio my reasoning is that it's enough to make sure all the functions/includes work on a single compiler

It wouldn't be too much work to add gcc.

@DockedFerret800
Copy link
Copy Markdown
Contributor

DockedFerret800 commented Aug 8, 2025

Why are you only testing with CLang?

Two reasons mainly:

  • I thought the workflows were a bit of mess so I didn't want to touch them too much 😄
  • Since we're only testing standalone vs boost asio my reasoning is that it's enough to make sure all the functions/includes work on a single compiler

It wouldn't be too much work to add gcc.

Well, I believe this should be tested against everything Glaze is currently tested against - so GCC, clang and MSVC. I can submit a commit if you wish.

@stephenberry
Copy link
Copy Markdown
Owner

Thanks for this pull request! This will allow us to validate that boost-asio is still supported. Others or myself can make the required changes to get everything passing.

The threading test occasionally fails with GitHub Actions. I need to spend more time to figure out why, but on my local machine I could not replicate the issue, so I think it is affected by the virtual environment. I'm going to have to figure out a debug workflow via codespaces I think. But, for now it can be ignored.

@azais-corentin
Copy link
Copy Markdown
Contributor Author

I'll work on this again soon.
I just wanted to note that we should probably test with a few different Asio/Boost.Asio versions because they've recently removed a few deprecated functions.

@packit-as-a-service
Copy link
Copy Markdown

@packit-as-a-service
Copy link
Copy Markdown

One of the tests failed for 932c813. @admin check logs None, packit dashboard https://dashboard.packit.dev/jobs/srpm/467534 and external service dashboard https://copr.fedorainfracloud.org/coprs/build/9546385/

@azais-corentin
Copy link
Copy Markdown
Contributor Author

I have updated the workflow to test with multiple versions of clang (17, 18, 20) and gcc (12, 13, 14), each against two different Boost versions (1.88.0 and 1.73.0).

@azais-corentin azais-corentin marked this pull request as ready for review September 12, 2025 18:45
@stephenberry
Copy link
Copy Markdown
Owner

This looks good, thanks for the CMake cleanup! Give me the thumbs up and I'll merge it in.

@azais-corentin
Copy link
Copy Markdown
Contributor Author

You can merge this :)

@stephenberry
Copy link
Copy Markdown
Owner

Thanks so much for your work on this!

@stephenberry stephenberry merged commit c398e85 into stephenberry:main Sep 15, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Standalone asio include breaks Boost.Asio compatibility

4 participants