Avoid GCC ubsan contexpr bug and add asan CI#2288
Merged
stephenberry merged 6 commits intomainfrom Jan 31, 2026
Merged
Conversation
|
One of the tests failed for c7a825d. @admin check logs https://download.copr.fedorainfracloud.org/results/packit/stephenberry-glaze-2288/fedora-rawhide-ppc64le/10083041-glaze/builder-live.log, packit dashboard https://dashboard.packit.dev/jobs/copr/3207682 and external service dashboard https://copr.fedorainfracloud.org/coprs/build/10083041/ |
|
One of the tests failed for 46ba491. @admin check logs None, packit dashboard https://dashboard.packit.dev/jobs/copr/3207777 and external service dashboard https://copr.fedorainfracloud.org/coprs/build/10083150/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: Add ASan CI and Fix Memory Leaks
Summary
This PR adds AddressSanitizer CI testing and fixes several memory leaks detected by ASan.
Changes
New ASan CI Workflow
.github/workflows/sanitizers.ymlwith GCC 15 and ASan enableddetect_leaks=1to catch memory leaks in CIGCC+UBSan Constexpr Fix (Issue #2287)
include/glaze/core/reflect.hppconstexpr auto& HashInfo = hash_info<keys_t>inside the nested lambdaMemory Leak Fixes
glaze_asio.hpp
delete ptrin custom deleter for thread pool shared_ptrhttp_server.hpp (
streaming_utilsnamespace)send_periodic_data()- self-capturing lambda kept streaming connections alive indefinitelystream_collection()- same issueenable_shared_from_thispattern to properly break the reference cyclestream_collection()now copies the container to prevent dangling iterator issueshttp_client_test.cpp
/slow-streamtest handler usingenable_shared_from_thispatternTesting
All networking tests pass with ASan enabled: