Avoid erroring on nullable value types#2394
Merged
stephenberry merged 1 commit intomainfrom Mar 22, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
error_on_missing_keysfor value types wrapping nullable typesFixes #2389
When a struct uses
glaze::valueto serialize as one of its members (a "value type"), and that member is nullable (e.g.std::optional),error_on_missing_keysincorrectly treated the field as required. This is becauserequired_fields()checked nullability on the outer struct rather than the underlying type it serializes as.Changes
include/glaze/core/reflect.hpp— Added aglaze_value_tbranch torequired_fields()that unwraps the value type viaremove_meta_wrapper_tand checks nullability on the inner type. Applied in both themeta_has_requires_keypath and the default path.tests/json_test/json_test.cpp— Added a test verifying that a missing value-type field backed bystd::optionaldoes not produce amissing_keyerror, while non-nullable required fields still do.