internal linkage for constexpr variables for module use#2428
Merged
stephenberry merged 1 commit intomainfrom Apr 2, 2026
Merged
internal linkage for constexpr variables for module use#2428stephenberry merged 1 commit intomainfrom
stephenberry merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added inline to namespace-scope constexpr variables (giving them external linkage), and removed static from function templates.
constexpr functions are implicitly inline, but constexpr variables are not — they're implicitly const, and const at namespace scope has internal linkage in C++.
So:
This distinction doesn't matter in traditional header-based code — each TU gets its own identical copy and the linker is fine with it. But with C++ modules, GCC 15 enforces [basic.link]/[module.reach]: a module interface unit must not expose entities with internal linkage (TU-local entities) in any reachable declaration. Since templates and inline functions in the module interface reference these constants, the internal-linkage variables "leak" through, and GCC rightfully rejects it.