Skip to content

[feat] use configuration files#65

Open
unsync wants to merge 3 commits intostevegrunwell:developfrom
unsync:feat/use-config-file
Open

[feat] use configuration files#65
unsync wants to merge 3 commits intostevegrunwell:developfrom
unsync:feat/use-config-file

Conversation

@unsync
Copy link
Copy Markdown

@unsync unsync commented Feb 14, 2021

The goal is to use a config file for excludes/includes, allowing to define custom paths.
The default config files are created if they do not exists, with the same defaults as the current script.

Tested on MacOS 11.2

@unsync unsync force-pushed the feat/use-config-file branch from 6ea05a8 to b51d50e Compare February 14, 2021 15:38
@j-f1
Copy link
Copy Markdown

j-f1 commented Feb 14, 2021

How would this work if Asimov were to add additional paths to either of these lists in the future?

@unsync unsync force-pushed the feat/use-config-file branch from 97526a1 to 0148fa0 Compare February 14, 2021 15:53
@unsync
Copy link
Copy Markdown
Author

unsync commented Feb 14, 2021

@j-f1 well, it would not work as it is ^^
you got several way to look at it depending on the direction wanted for this tool :

  • you set sane default during inital install, then you got full control over the sentinels
  • you add logic in the script that adds the new sentinels wanted by asimov

one could argue that the defaults by asimov do not work in their use case (maybe some wants to backup their node_modules, then reliyng only on defaults is a drawdown).

This PR is mostly a base for discussions, you could imagine several lists (defaults, excludes, overrides, etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants