Add embedded_hal 1.0, keep support for latest 0.2.x#240
Open
zheylmun wants to merge 1 commit intostm32-rs:masterfrom
Open
Add embedded_hal 1.0, keep support for latest 0.2.x#240zheylmun wants to merge 1 commit intostm32-rs:masterfrom
zheylmun wants to merge 1 commit intostm32-rs:masterfrom
Conversation
Followed example in stm32f4xx-hal All crate references to the hal use the lib export, and both the 1.0 traits and 0.2.x traits can be supported Note that none of the implementation is done for the 1.0.0 traits, just organizing the dependencies to allow it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followed example of how to support both 0.2.x and 1.0.0 in stm32f4xx-hal
All crate references to the existing hal use the lib export, and both the 1.0 traits and 0.2.x traits can now be supported.
Note that none of the implementation is done for the 1.0.0 traits, just organizing the existing dependencies to allow it.
I did update some dependencies here, I can roll that back if there's a desire for it.