React Native Web: Fix inconsistent example stories#33891
React Native Web: Fix inconsistent example stories#33891jonniebigodes merged 3 commits intostorybookjs:nextfrom
Conversation
…istent with other templates - Use `satisfies Meta<typeof Page>` pattern and `StoryObj` type in the TS template to match Button and Header stories - Add `type Story = StoryObj<typeof meta>` and annotate exports accordingly - Remove leftover FIXME comment from both JS and TS Page story templates Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughTwo Storybook story files are updated. The JavaScript version removes a commented assertion line. The TypeScript version modernizes story type declarations by introducing Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Package BenchmarksCommit: No significant changes detected, all good. 👏 |
jonniebigodes
left a comment
There was a problem hiding this comment.
@danielalanbates, thanks for taking the time to put together this pull request and help fix the examples. We appreciate it 🙏 !
I've checke,d and it looks good on my end.
Will gladly merge this once the checklist clears.
Hope you have a fantastic day.
Stay safe
|
Thank you for the review! Glad it helps. 🙏 |
Closes #33845
Summary
This PR fixes: [Bug]: React Native Web - Inconsistent example stories
Changes
Testing
Please review the changes carefully. The fix was verified against the existing test suite.
This PR was created with the assistance of Claude Sonnet 4.6 by Anthropic | effort: low. Happy to make any adjustments!
Summary by CodeRabbit