icons of vacant shops are sometimes wrong

[legofahrrad]

How to Reproduce

Search for vacant shops that have additional tags, such as building=house or indoor=room
The icons of the house or the room are displayed on the map, but in the "editing window" is the correct icon for vacant shops.

Locations to reproduce: E. g.: here or here

Expected Behavior

Show the correct icon on the map

Versions affected

v49

[matkoniecz]

that appears to be one of consequences of westnordost/osmfeatures#16 (normally they also got wrong icon - of shop=yes, not of shop:disused=*)

I wanted to look into it at some point, but first I want to complete already started stuff and then I would need to figure out how to configure gradle to use local version of osmfeatures

[westnordost]

Hmm, I am not sure what to do about that that wouldn't be hacky. Implementing the mentioned missing feature westnordost/osmfeatures#16 would fix it, so I am closing this one as it should be solved upstream.

[FloEdelmann]

westnordost/osmfeatures#16 is now implemented

[westnordost]

I fear this can not be solved easily even with #6140 implemented. The reason is that of course only the icon for one preset can be displayed, but what if the tags on the element match several presets? E.g. building=commercial + disused:shop=yes. Then, the feature with the higher priority is selected.
What is the priority of which preset is defined by the iD tagging schema. The preset for disused:shop just has a very low priority (matchScore):

https://github.com/openstreetmap/id-tagging-schema/blob/c2b5f7d0370e050a879cd5120d3f21186798e244/dist/presets.json#L20014-L20028