chore: refactor package to use a dedicated submodule for the tests#154
Closed
ccoVeille wants to merge 2 commits intostretchr:masterfrom
ccoveille-forks:simplify-dependencies
Closed
chore: refactor package to use a dedicated submodule for the tests#154ccoVeille wants to merge 2 commits intostretchr:masterfrom ccoveille-forks:simplify-dependencies
ccoVeille wants to merge 2 commits intostretchr:masterfrom
ccoveille-forks:simplify-dependencies
Conversation
This allows to simplify the dependencies of the main module
Author
|
This might be a naive approach, but it would make the package depency free. I opened because I was surprised to see this PR being opened in testify that uses |
This was referenced May 27, 2025
I'm unsure since when it's broken
geseq
reviewed
May 28, 2025
Collaborator
geseq
left a comment
There was a problem hiding this comment.
Nice one. Perhaps we should add a Makefile with test commands for easy testing locally.
Author
Contributor
|
I suspect that this new project structure breaks coverage reporting: tested code and tests must be in the same package. |
Author
|
Yes, unfortunately |
Author
|
Based on how much testify is extensively used in test, it won't be possible to replace testify by something else using stdlib. I tried to see if it was possible to remove testify dependency from objx, but it won't be possible. So the way is more in that direction |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This allows to simplify the dependencies of the main module
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
task testtask lint