added since on line level changes#3086
Open
shivambagadia23 wants to merge 2 commits intostryker-mutator:masterfrom
Open
added since on line level changes#3086shivambagadia23 wants to merge 2 commits intostryker-mutator:masterfrom
shivambagadia23 wants to merge 2 commits intostryker-mutator:masterfrom
Conversation
rouke-broersma
requested changes
Oct 28, 2024
Member
rouke-broersma
left a comment
rouke-broersma
left a comment
There was a problem hiding this comment.
Please revert the files to file scope namespace
Member
|
/azp run |
| // A git repository has been detected, calculate the diff to filter | ||
| var repository = _gitInfoProvider.Repository; | ||
| var commit = _gitInfoProvider.DetermineCommit(); | ||
| public TestSet Tests { get; } |
There was a problem hiding this comment.
Why did we move these inside class?
Author
There was a problem hiding this comment.
@inishantmishra We did not change anything there it was like that only
| if (mutant.ResultStatus != MutantStatus.NoCoverage) | ||
| { | ||
| mutant.ResultStatus = MutantStatus.Pending; | ||
| mutant.ResultStatusReason = "Mutant changed compared to target commit"; |
Member
There was a problem hiding this comment.
The status reason is not correct, the mutant has not been changed but a covering test has been changed
Comment on lines
+78
to
+82
| if (mutant.ResultStatus != MutantStatus.NoCoverage) | ||
| { | ||
| mutant.ResultStatus = MutantStatus.Pending; | ||
| mutant.ResultStatusReason = "Mutant changed compared to target commit"; | ||
| } |
Member
There was a problem hiding this comment.
Why do you not use SetMutantStatusForFileChanged?
Comment on lines
+109
to
+112
| if (mutant.ResultStatus != MutantStatus.NoCoverage) | ||
| { | ||
| mutant.ResultStatus = MutantStatus.Pending; | ||
| mutant.ResultStatusReason = "Mutant changed compared to target commit"; |
Member
There was a problem hiding this comment.
Why do you not use ResetMutantStatusForChangedTests?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.