Redesign Project analysis

[dupdob]

improve design of project analysis logic to streamline it.

[Copilot]

Pull request overview

Refactors project analysis/initialisation to streamline Buildalyzer usage and improve how Stryker identifies mutable projects + their associated test projects (especially across solution/project modes and target frameworks).

Changes:

• Introduces TargetsForMutation, ProjectAnalyzerContext, and mutable project/target tracking types to centralize analysis state and framework/platform selection.
• Refactors InputFileResolver to use the new analysis context and to map test projects to source projects via assembly/project references.
• Updates solution/platform handling (“AnyCPU” vs “Any CPU”), logging behavior, and adjusts unit tests accordingly.

Reviewed changes

Copilot reviewed 14 out of 16 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
src/Stryker.Utilities/Buildalyzer/IAnalyzerResultExtensions.cs	Adds helper extensions for validating overall analysis results across frameworks.
src/Stryker.TestRunner.MicrosoftTestPlatform.UnitTest/MicrosoftTestPlatformRunnerPoolTests.cs	Makes runner creation synchronization explicit to reduce flakiness in disposal tests.
src/Stryker.Solutions/SolutionFile.cs	Adjusts solution/platform normalization and adds per-project configuration lookup helper.
src/Stryker.Solutions.Test/SolutionFileShould.cs	Updates assertions for normalized solution platform naming (“Any CPU”).
src/Stryker.Core/Stryker.Core/ProjectComponents/SourceProjects/SourceProjectInfo.cs	Replaces SolutionInfo with TargetsForMutation on source project metadata.
src/Stryker.Core/Stryker.Core/Initialisation/TargetsForMutation.cs	New: encapsulates chosen config/platform, selected projects, and restore-at-solution-level behavior.
src/Stryker.Core/Stryker.Core/Initialisation/ProjectAnalyzerContext.cs	New: wraps Buildalyzer project analysis, framework selection, and detailed logging.
src/Stryker.Core/Stryker.Core/Initialisation/MutableProjectTree.cs	New: tracks a project’s candidate targets and their validity for mutation.
src/Stryker.Core/Stryker.Core/Initialisation/MutableProjectTarget.cs	New: links a mutable target to the test-project analysis results that cover it.
src/Stryker.Core/Stryker.Core/Initialisation/InputFileResolver.cs	Major refactor: drives analysis via contexts and builds a test↔source mapping using the new tree types.
src/Stryker.Core/Stryker.Core/Initialisation/InitialisationProcess.cs	Switches build step to read config/platform from TargetsForMutation.
src/Stryker.Core/Stryker.Core.UnitTest/Mutators/CollectionExpressionMutatorTests.cs	Whitespace-only test fixture cleanup.
src/Stryker.Core/Stryker.Core.UnitTest/Initialisation/ProjectOrchestratorTests.cs	Updates mocks/verifications to assert EnvironmentOptions passed into Buildalyzer builds.
src/Stryker.Core/Stryker.Core.UnitTest/Initialisation/InputFileResolverTests.cs	Updates expected framework selection behavior and Buildalyzer invocation assertions.
src/Stryker.CLI/Stryker.CLI/Logging/LoggingInitializer.cs	Tweaks diagnostic-mode console log level selection (at least Debug).
src/.run/FullFrameworkApp.Test.run.xml	Updates IDE run configuration working directory.

Comments suppressed due to low confidence (1)

src/Stryker.Core/Stryker.Core/Initialisation/InputFileResolver.cs:499

• ArgumentNullException is constructed with path as the parameter name, but it should use nameof(path) so tooling reports the correct parameter name regardless of runtime value.

    private string FindProjectFile(string path)
    {
        if (string.IsNullOrEmpty(path))
        {
            throw new ArgumentNullException(path, "Project path cannot be null or empty.");
        }

[Copilot]

Pull request overview

Copilot reviewed 15 out of 17 changed files in this pull request and generated 4 comments.

[Copilot]

Pull request overview

Copilot reviewed 16 out of 18 changed files in this pull request and generated 3 comments.

[Copilot]

Pull request overview

Copilot reviewed 17 out of 18 changed files in this pull request and generated 7 comments.

[Copilot]

Pull request overview

Copilot reviewed 18 out of 19 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 18 out of 19 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 18 out of 19 changed files in this pull request and generated 3 comments.

[Copilot]

Pull request overview

Copilot reviewed 18 out of 19 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 18 out of 19 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 18 out of 19 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (2)

src/Stryker.Core/Stryker.Core/Initialisation/InitialisationProcess.cs:73

• BuildProjects dereferences projects.First().TargetsForMutation without a null check. Since SourceProjectInfo.TargetsForMutation is currently not guaranteed to be initialized (it’s a settable property), this can throw at runtime (and will break existing unit tests that create SourceProjectInfo directly). Either guard against null here, or enforce non-null initialization of TargetsForMutation everywhere SourceProjectInfo is created.

    public void BuildProjects(IStrykerOptions options, IEnumerable<SourceProjectInfo> projects)
    {
        var solutionInfo = projects.First().TargetsForMutation;
        // pick configuration and platform from solution if available
        var configuration = solutionInfo?.Configuration ?? options.Configuration;
        var platform = solutionInfo?.Platform ?? options.Platform;
        var solutionFilePath = solutionInfo?.SolutionFilePath ?? options.SolutionPath;

src/Stryker.Core/Stryker.Core/Initialisation/InputFileResolver.cs:507

• FindProjectFile’s file-extension check is incorrect: FileSystem.Path.HasExtension(".csproj")/(".fsproj") checks the literal string (always true), so any existing file path will be treated as a valid project file. This can cause Stryker to accept non-project files and then fail later in analysis. Use an extension check on path itself (e.g., compare Path.GetExtension(path) or EndsWith(".csproj"/".fsproj") case-insensitively). Also, the ArgumentNullException should use nameof(path) as the parameter name, not the path value.

    private string FindProjectFile(string path)
    {
        if (string.IsNullOrEmpty(path))
        {
            throw new ArgumentNullException(path, "Project path cannot be null or empty.");
        }

        if (FileSystem.File.Exists(path) && (FileSystem.Path.HasExtension(".csproj") || FileSystem.Path.HasExtension(".fsproj")))
        {
            return path;

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud