🔥(backend) remove i18n and localization from Django admin#110
Open
StephanMeijer wants to merge 1 commit intomainfrom
Open
🔥(backend) remove i18n and localization from Django admin#110StephanMeijer wants to merge 1 commit intomainfrom
StephanMeijer wants to merge 1 commit intomainfrom
Conversation
9b158df to
e2afbda
Compare
There was a problem hiding this comment.
Pull request overview
This PR removes the backend’s remaining Django i18n/localization plumbing, mainly to make the admin render only fixed English strings and to drop the unused translation workflow around it.
Changes:
- Disable Django i18n in settings and remove locale-specific middleware/context configuration.
- Replace
{% trans %}usage and lazy translation wrappers in admin-facing templates/models/apps with plain strings. - Delete Crowdin-related project files from the local Docker setup.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/backend/find/settings.py |
Disables Django i18n, removes locale paths/context processor, and drops locale middleware. |
src/backend/core/templates/admin/selftest.html |
Replaces translated admin self-test UI labels with static English text. |
src/backend/core/templates/admin/index.html |
Replaces translated custom admin index labels with static English text. |
src/backend/core/templates/admin/core/services/change_list.html |
Replaces translated service changelist action text with a static label. |
src/backend/core/models.py |
Replaces lazy-translated model verbose names with plain strings. |
src/backend/core/apps.py |
Replaces the app config verbose name translation wrapper with a plain string. |
crowdin/config.yml |
Removes the Crowdin CLI configuration file. |
compose.yml |
Removes the local Crowdin Docker service. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| TIME_ZONE = "UTC" | ||
| USE_I18N = True | ||
| USE_I18N = False |
Collaborator
Author
There was a problem hiding this comment.
Sounds like we should not run manage.py makemessages / compilemessages.
Comment on lines
98
to
100
| dockerize: | ||
| image: jwilder/dockerize | ||
|
|
|
I have mixed feelings about this. Even if it's not widely used, i18n is used… |
e2afbda to
0cd7521
Compare
Signed-off-by: Stephan Meijer <me@stephanmeijer.com>
0cd7521 to
05b0298
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
USE_I18N = False) and removeLocaleMiddlewareLOCALE_PATHS, i18n template context processor, andgettext_lazyusage{% trans %}tags with plain strings in admin templatesnoChangelog