Skip to content

✨(devex) add LIVEKIT_INTERNAL_URL for server-to-server communication #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cameledev wants to merge 1 commit into from
Closed

✨(devex) add LIVEKIT_INTERNAL_URL for server-to-server communication #1172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions env.d/development/common.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ OIDC_RS_CLIENT_SECRET=ThisIsAnExampleKeyForDevPurposeOnly
LIVEKIT_API_SECRET=secret
LIVEKIT_API_KEY=devkey
LIVEKIT_API_URL=http://127.0.0.1.nip.io:7880
LIVEKIT_INTERNAL_URL=http://livekit:7880
LIVEKIT_VERIFY_SSL=False
ALLOW_UNREGISTERED_ROOMS=False

Expand Down
6 changes: 5 additions & 1 deletion src/backend/core/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,11 @@ def create_livekit_client(custom_configuration=None):
custom_session = aiohttp.ClientSession(connector=connector)

# Use default configuration if none provided
configuration = custom_configuration or settings.LIVEKIT_CONFIGURATION
configuration = {
**(custom_configuration or settings.LIVEKIT_CONFIGURATION),
"url": settings.LIVEKIT_INTERNAL_URL
or (custom_configuration or settings.LIVEKIT_CONFIGURATION)["url"],
}
Comment on lines +215 to +219
Copy link
Copy Markdown
Collaborator

@lebaudantoine lebaudantoine Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s a bit hard to follow, something like this might be clearer with an explicit comment:

Suggested change
configuration = {
**(custom_configuration or settings.LIVEKIT_CONFIGURATION),
"url": settings.LIVEKIT_INTERNAL_URL
or (custom_configuration or settings.LIVEKIT_CONFIGURATION)["url"],
}
configuration = custom_configuration or settings.LIVEKIT_CONFIGURATION
# ... clear commment it's necessary for the docker compose stack
if settings.LIVEKIT_INTERNAL_URL is not None:
configuration["url"] = settings.LIVEKIT_INTERNAL_URL


return LiveKitAPI(session=custom_session, **configuration)

Expand Down
5 changes: 5 additions & 0 deletions src/backend/meet/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,6 +619,11 @@ class Base(Configuration):
),
"url": values.Value(environ_name="LIVEKIT_API_URL", environ_prefix=None),
}
# Internal URL for server-to-server LiveKit API calls (e.g. container-to-container).
# Defaults to LIVEKIT_API_URL when not set.
LIVEKIT_INTERNAL_URL = values.Value(
"", environ_name="LIVEKIT_INTERNAL_URL", environ_prefix=None
Copy link
Copy Markdown
Collaborator

@lebaudantoine lebaudantoine Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default shoud be None, not ""

)
LIVEKIT_FORCE_WSS_PROTOCOL = values.BooleanValue(
False, environ_name="LIVEKIT_FORCE_WSS_PROTOCOL", environ_prefix=None
)
Expand Down
Loading
⚡