✨(frontend) add emoji reactions to chat messages#888
Open
nono wants to merge 1 commit intosuitenumerique:mainfrom
Open
✨(frontend) add emoji reactions to chat messages#888nono wants to merge 1 commit intosuitenumerique:mainfrom
nono wants to merge 1 commit intosuitenumerique:mainfrom
Conversation
|
Collaborator
lebaudantoine
left a comment
lebaudantoine
left a comment
There was a problem hiding this comment.
Hi, I’ve quickly gone through your PR. Thanks for your proposal! I haven’t reviewed the frontend layout and UI yet, but I focused on how reactions are sent to other participants. That's promising.
I think you’re almost there. I would suggest, introducing a new topic specifically for chat message reactions.
Regarding the notification feature, I think it does too much at the moment; it was initially designed for toast notifications. I would introduce a proper chat feature, and refactor the existing code;
Do you allow me to work on your PR?
Author
|
Great, yes, feel free to work on it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Allow participants to react to chat messages with emojis, similar to reactions in messaging apps like Slack or Teams. This enhances communication by providing a lightweight way to acknowledge or respond to messages without typing a reply.
https://github.com/orgs/suitenumerique/projects/11?pane=issue&itemId=131558444
Proposal
Add emoji reactions to chat messages, synchronized in real-time across all participants via LiveKit data channels.