Conversation
Its value persisted between hyppy() function calls by accident.
Mimic the DOS version's frame rate limiting more accurately.
veikkos
approved these changes
Dec 3, 2023
This was referenced Apr 7, 2024
Merged
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
LMaaraglobal. Its value stayed the same betweenhyppy()function calls by pure accident.Mimic frame rate limiter more like the original DOS version does it, i.e. wait that a new frame starts before rendering instead of just waiting for any change to framecount. Also make frame counting more accurate.
Use double precision floating point arithmetic everywhere. With single precision floating points, implementation details of the compiler affect how calculations are made, e.g. when to widen the number to double precision and convert back to single decision. As such, using double precision everywhere isn't probably worse than compling the original code with Free Pascal, which might have different implementation details than Turbo Pascal that was originally used.
Because of the aforementioned compiler implementation details, using double precision is vital to be able to reproduce the precise computations in another programming language (see https://github.com/akheron/skijump3-remake).