Open
Conversation
Member
|
I'll test this on Windows! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request changes the implementation of the
SJ3HELP.toansifunction, so that the passed text in the IBM865 code page is converted not to an extended ASCII, but the UTF-8 encoding. This function was used for the*.TXTfile output, and has been reused here for the console output also. This should result in a correct display of special characters on modern (especially non-Nordic?) systems.A few tweaks, rearrangements and workarounds were needed for the
SJ3UNIT.lopputextprocedure, as theCrt.Windowprocedure seems not to handle multi-byte text output particularly well.Outro screen (Ubuntu 24.04.4 LTS + fpc 3.2.2):
This probably needs some testing on Windows & macOS too before merging.