This repository was archived by the owner on Jul 15, 2023. It is now read-only.
Fix: When destroying a component with an not initialized swiper.#341
Merged
surmon-china merged 1 commit intosurmon-china:swiper5from Mar 12, 2020
HappyGray24:hotfix/destroying-not-initialized-swiper
Merged
Fix: When destroying a component with an not initialized swiper.#341surmon-china merged 1 commit intosurmon-china:swiper5from HappyGray24:hotfix/destroying-not-initialized-swiper
surmon-china merged 1 commit intosurmon-china:swiper5from
HappyGray24:hotfix/destroying-not-initialized-swiper
Conversation
|
Is the maintainer gone , haven't seen any progress on this repo |
DarkRiDDeR
added a commit
to DarkRiDDeR/vue-swiper-ave2
that referenced
this pull request
Apr 30, 2019
|
@surmon-china Please merge 🙏 |
Owner
|
Thanks! |
Owner
|
The change will merge to v4.0.0 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you destroy a component, where swiper not initialized (swiper.initialized === undefined || swiper.initialized === false), then an error occurs: "Failed to execute 'remove' on 'DOMTokenList'."
Fix the code on the per-line 115 file
~/src/ssr.json:that not to destroy the not yet initialized swiper../
#340